aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
5.85k stars 3.54k forks source link

[Bug][move-compiler-v2] Double-check whether path canonicalization is needed for `move-model::add_source` and elsewhere #13192

Open brmataptos opened 2 weeks ago

brmataptos commented 2 weeks ago

🐛 Bug

move-compiler-v2 and move-model use file names as keys for things. But they are also used as user-visible outputs. We need to double-check that we aren't double-compiling or missing properties due to files reachable on multiple paths somehow.

brmataptos commented 2 weeks ago

For example, see move-model/src/lib.rs near line 188:

target_sources_names.contains(fname.as_str()),