[not for review] test concurrent opt-in

igor-aptos commented 2 weeks ago

Description

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

[ ] I have read and followed the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 2 weeks ago

⏱️ 3h 40m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8944735980/job/24572306295) | 1h 48m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8944736031/job/24572305820) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8944736029/job/24572307191) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8944735980/job/24572306295) | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8944736008/job/24572307891) | 53m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8944736008/job/24572307891) | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/8944736011/job/24572297839) | 16m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944736011/job/24572297839) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572309219) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572309219) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8944736025/job/24572298986) | 11m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8944736025/job/24572298986) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8944736008/job/24572307047) | 5m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8944736008/job/24572307047) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8944735935/job/24572313187) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735935/job/24572313187) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8944735972/job/24572296290) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944736001/job/24572296247) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944736006/job/24572296430) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735972/job/24572296290) | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572304738) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572304738) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8944736008/job/24572306887) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944736008/job/24572306887) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8944736009/job/24572296603) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735968/job/24572296139) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944736018/job/24572296791) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944736009/job/24572296603) | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8944736029/job/24572297567) | 30s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944736031/job/24572297462) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735980/job/24572297240) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944736029/job/24572297567) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8944735935/job/24572303942) | 13s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735935/job/24572303942) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572304961) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572304961) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8944736008/job/24572298753) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944736008/job/24572298753) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8944735905/job/24572295789) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735913/job/24572295707) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735928/job/24572295694) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735905/job/24572295789) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8944735920/job/24572295953) | 7s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735931/job/24572295693) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735906/job/24572296047) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735920/job/24572295953) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8944735935/job/24572298111) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735935/job/24572298111) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572298761) | 3s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572298761) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8944735915/job/24572298123) | 3s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735915/job/24572298123) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572305130) | 2s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8944735973/job/24572305130) |

🚨 3 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg
rust-targeted-unit-tests	53m	15m
execution-performance / single-node-performance	37m	25m
framework-upgrade-determinator	3m	4m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.6%. Comparing base (976d157) to head (8ebdc78).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## igor/test_after_fa_with_concurrent #13195 +/- ## =================================================================== Coverage 57.5% 57.6% =================================================================== Files 834 834 Lines 198319 198319 =================================================================== + Hits 114208 114244 +36 + Misses 84111 84075 -36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aptos-labs / aptos-core