[storage] turn on feature flag for remove_detailed_error_from_hash

areshand commented 2 weeks ago

Description

for v1.12 testnet release

Type of Change

[x] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[x] Validator Node
[x] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

The internal error info was tested previously through unit tests

with devnet

Before the feature is on

transaction https://explorer.aptoslabs.com/txn/1319701?network=devnet Move abort in 0x1::from_bcs: EINVALID_UTF8(0x10001): UTF8 check failed in conversion from bytes to string [with detail error]

Run governance proposal to enable the feature https://explorer.aptoslabs.com/txn/1325739?network=devnet

We still have the error details as expected. Devnet is also running healthy https://explorer.aptoslabs.com/txn/1327821?network=devnet

Key Areas to Review

Checklist

[ ] I have read and followed the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 2 weeks ago

⏱️ 15h total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9066136022/job/24914037858) | 3h 26m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24832108127) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834993408) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9066136022/job/24914037858) | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834356218) | 1h 59m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9009387174/job/24753483278) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9035680147/job/24830964256) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9035777106/job/24831253316) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9035925211/job/24831704892) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834356218) (+2 more) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036768965/job/24834347122) | 1h 25m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9009387170/job/24753472927) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9035680143/job/24830954577) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9035777098/job/24831243048) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9035925207/job/24831696032) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9036768965/job/24834347122) (+2 more) | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834356395) | 1h 11m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925211/job/24831704725) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834356395) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834355977) | 55m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387174/job/24753482986) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9035680147/job/24830963596) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035777106/job/24831252862) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925211/job/24831704575) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834355977) (+2 more) | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/9036768967/job/24834347398) | 53m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9035680146/job/24830954559) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035777113/job/24831242146) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768967/job/24834347398) | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/9036768939/job/24834346907) | 53m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925208/job/24831684837) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9036768939/job/24834346907) | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/9036768972/job/24834463967) | 46m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9035925215/job/24831798913) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9036768972/job/24834463967) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/9056648543/job/24879499645) | 42m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680053/job/24830969937) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035776411/job/24831245783) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925231/job/24831700124) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768927/job/24834362623) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9056648543/job/24879499645) (+5 more) | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834992823) | 33m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24832107951) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834992823) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834368610) | 31m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24831701076) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834368610) | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834993013) | 27m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24832107459) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834993013) | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834992304) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24832107818) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834992304) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834355588) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387174/job/24753483121) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680147/job/24830963370) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035777106/job/24831253115) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925211/job/24831704377) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834355588) (+2 more) | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834355765) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925211/job/24831705085) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834355765) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/9036768962/job/24834346540) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387177/job/24753472426) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680145/job/24830953844) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035777105/job/24831231473) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925205/job/24831684935) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768962/job/24834346540) (+2 more) | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/9036768948/job/24834347265) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925210/job/24831685462) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768948/job/24834347265) | | [execution-performance / test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036768972/job/24834347187) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925215/job/24831685414) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768972/job/24834347187) | | [test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834362188) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24831693156) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834362188) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/9036768952/job/24834346461) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387180/job/24753472431) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680142/job/24830953775) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035777117/job/24831231526) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925198/job/24831685130) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768952/job/24834346461) (+2 more) | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834993226) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24832107649) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834993226) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036768927/job/24834352426) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387059/job/24753476988) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680053/job/24830960147) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035776411/job/24831237363) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925231/job/24831691546) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768927/job/24834352426) (+4 more) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834347681) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387174/job/24753472919) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680147/job/24830954602) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035777106/job/24831242870) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925211/job/24831696402) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768949/job/24834347681) (+2 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036768932/job/24834346600) | 30s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387060/job/24753471996) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680058/job/24830953659) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035776412/job/24831230142) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925242/job/24831684822) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768932/job/24834346600) (+4 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036768927/job/24834347167) | 24s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387059/job/24753472157) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680053/job/24830954342) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035776411/job/24831230465) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925231/job/24831685739) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768927/job/24834347167) (+4 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036768924/job/24834346690) | 24s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387069/job/24753471977) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680065/job/24830953500) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035776408/job/24831230093) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925239/job/24831684888) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768924/job/24834346690) (+4 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036768922/job/24834347482) | 24s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9009387055/job/24753472188) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035680046/job/24830954027) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035776406/job/24831230415) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925238/job/24831685681) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768922/job/24834347482) (+4 more) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834361982) | 20s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24831693016) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834361982) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834356719) | 5s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24831686182) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834356719) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834361748) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9035925294/job/24831692768) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036768970/job/24834361748) |

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
rust-images / rust-all	19m	14m
rust-lints	5m	9m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

msmouse commented 2 weeks ago

enable here for devnet genesis as well, please:

https://github.com/aptos-labs/aptos-core/blob/bbf569abd260d94bc30fe96da297d2aecb193644/types/src/on_chain_config/aptos_features.rs#L134-L137

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 6.06061% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 57.6%. Comparing base (6cdd4c2) to head (bf5010f). Report is 5 commits behind head on main.

Files	Patch %	Lines
types/src/transaction/mod.rs	0.0%	23 Missing :warning:
types/src/proof/definition.rs	0.0%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #13197 +/- ## ========================================= - Coverage 57.6% 57.6% -0.1% ========================================= Files 834 834 Lines 198397 198430 +33 ========================================= + Hits 114318 114320 +2 - Misses 84079 84110 +31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.