search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
5.85k stars 3.54k forks source link

Move from test to nextest for coverage too #13200

Open zi0Black opened 2 weeks ago

zi0Black commented 2 weeks ago

Description

Test should be run using nextest so tests coverage should work the same way.

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

This PR and cron execution.

Key Areas to Review

N/A

Checklist

trunk-io[bot] commented 2 weeks ago
⏱️ 1h 27m total CI duration on this PR | Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/8946483434/job/24577187634) | 17m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483434/job/24577187634)  | | [rust-smoke-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/8946483434/job/24577187770) | 17m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483434/job/24577187770)  | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/8946483419/job/24577187611) | 14m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483419/job/24577187611)  | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577198846) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577198846)  | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8946483435/job/24577196325) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483435/job/24577196325)  | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577195441) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577195441)  | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8946483376/job/24577199304) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483376/job/24577199304)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8946483441/job/24577188976) | 3m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8946483406/job/24577187321) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483441/job/24577188976)  | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8946483435/job/24577196432) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483435/job/24577196432)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8946483437/job/24577186898) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483413/job/24577186745) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483437/job/24577186898)  | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8946483435/job/24577196181) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483435/job/24577196181)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8946483422/job/24577186715) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483444/job/24577187030) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483422/job/24577186715)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8946483435/job/24577187962) | 17s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483435/job/24577187962)  | | [upload-to-codecov](https://github.com/aptos-labs/aptos-core/actions/runs/8946483434/job/24577544992) | 15s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483434/job/24577544992)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8946483380/job/24577186605) | 14s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483212/job/24577185932) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483380/job/24577186605)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8946483376/job/24577192988) | 12s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483376/job/24577192988)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577189782) | 9s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8946483257/job/24577186424) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577189782)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577195326) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577195326)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8946483215/job/24577185945) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483378/job/24577186409) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483215/job/24577185945)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8946483379/job/24577189122) | 5s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8946483213/job/24577186068) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483379/job/24577189122)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8946483376/job/24577189480) | 4s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8946483217/job/24577186022) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483376/job/24577189480)  | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577195560) | 2s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8946483452/job/24577195560)  |

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-unit-coverage 14m 19m -27%
rust-move-tests 3m 8m -62%
rust-targeted-unit-tests 3m 14m -79%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.0%. Comparing base (8aa625d) to head (da22c73). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13200 +/- ## =========================================== - Coverage 57.6% 33.0% -24.6% =========================================== Files 834 1759 +925 Lines 198264 338069 +139805 =========================================== - Hits 114212 111871 -2341 - Misses 84052 226198 +142146 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 days ago

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> da22c7335157f310d974d444d9dc0c0b77ed3a69

github-actions[bot] commented 4 days ago

Forge is running suite realistic_env_max_load on da22c7335157f310d974d444d9dc0c0b77ed3a69

github-actions[bot] commented 4 days ago

:white_check_mark: Forge suite realistic_env_max_load success on da22c7335157f310d974d444d9dc0c0b77ed3a69

two traffics test: inner traffic : committed: 8284 txn/s, latency: 4730 ms, (p50: 4500 ms, p90: 5400 ms, p99: 10200 ms), latency samples: 3579000
two traffics test : committed: 100 txn/s, latency: 1871 ms, (p50: 1800 ms, p90: 2100 ms, p99: 6100 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.204, avg: 0.202", "QsPosToProposal: max: 0.230, avg: 0.213", "ConsensusProposalToOrdered: max: 0.432, avg: 0.427", "ConsensusOrderedToCommit: max: 0.354, avg: 0.344", "ConsensusProposalToCommit: max: 0.782, avg: 0.770"]
Max round gap was 1 [limit 4] at version 1845111. Max no progress secs was 4.889667 [limit 15] at version 1845111.
Test Ok
github-actions[bot] commented 4 days ago

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> da22c7335157f310d974d444d9dc0c0b77ed3a69

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> da22c7335157f310d974d444d9dc0c0b77ed3a69 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6866 txn/s, latency: 4830 ms, (p50: 4800 ms, p90: 8100 ms, p99: 8700 ms), latency samples: 247180
2. Upgrading first Validator to new version: da22c7335157f310d974d444d9dc0c0b77ed3a69
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1767 txn/s, latency: 15790 ms, (p50: 18900 ms, p90: 22000 ms, p99: 22800 ms), latency samples: 91920
3. Upgrading rest of first batch to new version: da22c7335157f310d974d444d9dc0c0b77ed3a69
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1731 txn/s, latency: 15687 ms, (p50: 19500 ms, p90: 22000 ms, p99: 23200 ms), latency samples: 91760
4. upgrading second batch to new version: da22c7335157f310d974d444d9dc0c0b77ed3a69
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3043 txn/s, latency: 9987 ms, (p50: 9900 ms, p90: 12000 ms, p99: 13200 ms), latency samples: 124800
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> da22c7335157f310d974d444d9dc0c0b77ed3a69 passed
Test Ok
github-actions[bot] commented 4 days ago

Forge is running suite realistic_env_max_load on da22c7335157f310d974d444d9dc0c0b77ed3a69

github-actions[bot] commented 3 days ago

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> da22c7335157f310d974d444d9dc0c0b77ed3a69

github-actions[bot] commented 3 days ago

:white_check_mark: Forge suite realistic_env_max_load success on da22c7335157f310d974d444d9dc0c0b77ed3a69

two traffics test: inner traffic : committed: 7798 txn/s, latency: 5026 ms, (p50: 4800 ms, p90: 5700 ms, p99: 12100 ms), latency samples: 3368860
two traffics test : committed: 100 txn/s, latency: 1903 ms, (p50: 1800 ms, p90: 2100 ms, p99: 5600 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.206, avg: 0.202", "QsPosToProposal: max: 0.274, avg: 0.243", "ConsensusProposalToOrdered: max: 0.477, avg: 0.429", "ConsensusOrderedToCommit: max: 0.383, avg: 0.364", "ConsensusProposalToCommit: max: 0.814, avg: 0.793"]
Max round gap was 1 [limit 4] at version 1624356. Max no progress secs was 4.81247 [limit 15] at version 1624356.
Test Ok
github-actions[bot] commented 3 days ago

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> da22c7335157f310d974d444d9dc0c0b77ed3a69

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> da22c7335157f310d974d444d9dc0c0b77ed3a69 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6789 txn/s, latency: 4877 ms, (p50: 4800 ms, p90: 7800 ms, p99: 9600 ms), latency samples: 237620
2. Upgrading first Validator to new version: da22c7335157f310d974d444d9dc0c0b77ed3a69
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1834 txn/s, latency: 15844 ms, (p50: 18400 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 91700
3. Upgrading rest of first batch to new version: da22c7335157f310d974d444d9dc0c0b77ed3a69
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1525 txn/s, latency: 16962 ms, (p50: 19400 ms, p90: 22400 ms, p99: 23800 ms), latency samples: 85400
4. upgrading second batch to new version: da22c7335157f310d974d444d9dc0c0b77ed3a69
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3518 txn/s, latency: 9101 ms, (p50: 9900 ms, p90: 12300 ms, p99: 12700 ms), latency samples: 137240
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> da22c7335157f310d974d444d9dc0c0b77ed3a69 passed
Test Ok