[not for review] Igor/test inline replace concurrent fa

igor-aptos commented 2 weeks ago

Description

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

[ ] I have read and followed the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 2 weeks ago

⏱️ 4h 2m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8951404600/job/24587699996) | 1h 44m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8951404628/job/24587699462) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8951404651/job/24587700204) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8951404600/job/24587699996) | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587701131) | 55m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587701131) | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/8951404641/job/24587694985) | 19m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404641/job/24587694985) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587701731) | 17m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587701731) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8951404635/job/24587696013) | 14m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8951404594/job/24587694645) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8951404635/job/24587696013) | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587698680) | 11m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587698680) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587701074) | 9m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587701074) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8951404623/job/24587705266) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404623/job/24587705266) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8951404593/job/24587694036) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404614/job/24587694286) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404636/job/24587694393) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404593/job/24587694036) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587701187) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587701187) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8951404609/job/24587694264) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404643/job/24587694431) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404588/job/24587694153) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404609/job/24587694264) | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8951404651/job/24587694873) | 31s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404628/job/24587694839) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404600/job/24587694591) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404651/job/24587694873) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8951404623/job/24587699204) | 17s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404623/job/24587699204) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8951404619/job/24587694458) | 11s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404566/job/24587693992) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404573/job/24587693910) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404619/job/24587694458) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8951404565/job/24587693969) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404571/job/24587694030) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404618/job/24587694320) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404565/job/24587693969) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587696252) | 10s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8951404584/job/24587694572) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587696252) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587698811) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587698811) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8951404623/job/24587695425) | 5s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404623/job/24587695425) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587695329) | 3s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587695329) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587698559) | 2s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587698559) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8951404617/job/24587695126) | 2s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8951404617/job/24587695126) |

🚨 6 jobs on the last run were significantly faster/slower than expected

| Job | Duration | vs 7d avg | Delta | |---|---|---|---| | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587701131) | 55m | [14m](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_750a2cec-81f6-4bb8-9b9c-80b3f99f60f6/1_7ceacf17-4410-42a7-88b5-f740e8c7268a?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | [![+288%](https://img.shields.io/badge/+288%25-A72218)](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_750a2cec-81f6-4bb8-9b9c-80b3f99f60f6/1_7ceacf17-4410-42a7-88b5-f740e8c7268a?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587698680) | 11m | [4m](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_e2165897-506f-48cf-af00-df19955c86e6/1_13527d5f-553d-4d07-8417-0178272b421c?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | [![+178%](https://img.shields.io/badge/+178%25-A72218)](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_e2165897-506f-48cf-af00-df19955c86e6/1_13527d5f-553d-4d07-8417-0178272b421c?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8951404635/job/24587696013) | 14m | [8m](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_f5552b2e-3021-44f5-b126-675f2b4babfd/1_0cd7d25e-fcfb-4f91-92d7-744e64d9f8c2?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | [![+70%](https://img.shields.io/badge/+70%25-A72218)](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_f5552b2e-3021-44f5-b126-675f2b4babfd/1_0cd7d25e-fcfb-4f91-92d7-744e64d9f8c2?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8951404638/job/24587701074) | 9m | [6m](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_750a2cec-81f6-4bb8-9b9c-80b3f99f60f6/1_7d010dff-1df6-488e-9fc4-e06173c41ad7?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | [![+62%](https://img.shields.io/badge/+62%25-A72218)](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_750a2cec-81f6-4bb8-9b9c-80b3f99f60f6/1_7d010dff-1df6-488e-9fc4-e06173c41ad7?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8951404600/job/24587699996) | 35m | [25m](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_00384b63-ffe4-46c6-9b0b-1034fd44569d/1_4cfc13c8-5fda-4429-b262-c2119596dfd3?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | [![+41%](https://img.shields.io/badge/+41%25-C84B25)](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_00384b63-ffe4-46c6-9b0b-1034fd44569d/1_4cfc13c8-5fda-4429-b262-c2119596dfd3?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8951404649/job/24587701731) | 17m | [13m](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_e2165897-506f-48cf-af00-df19955c86e6/1_a9d9fb68-fa86-4597-a953-ee0bdeb74a12?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) | [![+29%](https://img.shields.io/badge/+29%25-E87A30)](https://app.trunk.io/aptoslabs/aptos-labs/aptos-core/ci-analytics/1_e2165897-506f-48cf-af00-df19955c86e6/1_a9d9fb68-fa86-4597-a953-ee0bdeb74a12?timeBased=true&numericAggregateFunctions=NUMERIC_AGGREGATE_FUNCTION_AVG&timeRange=7+days&conclusion=GIT_HUB_REPO_ACTIVITY_RUN_CONCLUSION_SUCCESS&utm_source=gh-comment) |

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.5%. Comparing base (976d157) to head (c309ece).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## igor/test_after_fa_with_concurrent #13202 +/- ## =================================================================== Coverage 57.5% 57.5% =================================================================== Files 834 834 Lines 198319 198319 =================================================================== Hits 114208 114208 Misses 84111 84111 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aptos-labs / aptos-core