[WIP] Use primary target for docgen and abigen

rahxephon89 commented 2 weeks ago

Description

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

[ ] I have read and followed the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 2 weeks ago

⏱️ 1h 26m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8953278943/job/24591626383) | 27m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278943/job/24591626383) | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/8953278946/job/24591623260) | 24m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278946/job/24591623260) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8953278944/job/24591623344) | 16m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278944/job/24591623344) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8953278943/job/24591626307) | 10m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278943/job/24591626307) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8953278935/job/24591630124) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278935/job/24591630124) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8953278943/job/24591626214) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278943/job/24591626214) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8953278948/job/24591623081) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278948/job/24591623081) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8953278940/job/24591623070) | 25s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278940/job/24591623070) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8953278935/job/24591625172) | 14s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278935/job/24591625172) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8953278943/job/24591623340) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278943/job/24591623340) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8953278933/job/24591623265) | 5s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278933/job/24591623265) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8953278935/job/24591623248) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278935/job/24591623248) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8953278938/job/24591623018) | 3s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278938/job/24591623018) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8953278934/job/24591623033) | 3s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8953278934/job/24591623033) |

🚨 4 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg
rust-move-tests	16m	8m
rust-targeted-unit-tests	27m	14m
rust-lints	10m	6m
rust-move-unit-coverage	24m	19m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.6%. Comparing base (5422dc1) to head (0474568). Report is 2 commits behind head on main.

Files	Patch %	Lines
...d_party/move/move-prover/move-docgen/src/docgen.rs	66.6%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #13204 +/- ## ======================================= Coverage 57.6% 57.6% ======================================= Files 834 834 Lines 198369 198369 ======================================= + Hits 114306 114310 +4 + Misses 84063 84059 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aptos-labs / aptos-core