Closed brmataptos closed 1 week ago
🚨 4 jobs on the last run were significantly faster/slower than expected
Job | Duration | vs 7d avg | Delta |
---|---|---|---|
framework-upgrade-determinator | 10m | 4m | |
rust-move-tests | 17m | 8m | |
rust-build-cached-packages | 8m | 5m | |
rust-targeted-unit-tests | 23m | 15m |
Attention: Patch coverage is 95.00000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 57.6%. Comparing base (
5422dc1
) to head (0d4151e
). Report is 4 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...v2/src/file_format_generator/function_generator.rs | 94.4% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
realistic_env_max_load
on 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
framework_upgrade
on 01b24e7e3548382dd25440b39a0438a993387f12
==> 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
compat
on 01b24e7e3548382dd25440b39a0438a993387f12
==> 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
compat
success on 01b24e7e3548382dd25440b39a0438a993387f12
==> 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0d4151ebe52ceeea579a9a4913e7518cb16d12d3 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6956 txn/s, latency: 4776 ms, (p50: 4800 ms, p90: 7500 ms, p99: 8100 ms), latency samples: 243480
2. Upgrading first Validator to new version: 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1476 txn/s, latency: 20253 ms, (p50: 19200 ms, p90: 29600 ms, p99: 29900 ms), latency samples: 87120
3. Upgrading rest of first batch to new version: 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1771 txn/s, latency: 16316 ms, (p50: 19700 ms, p90: 22700 ms, p99: 23200 ms), latency samples: 88560
4. upgrading second batch to new version: 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3387 txn/s, latency: 8983 ms, (p50: 9800 ms, p90: 12400 ms, p99: 13000 ms), latency samples: 145660
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0d4151ebe52ceeea579a9a4913e7518cb16d12d3 passed
Test Ok
realistic_env_max_load
success on 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
two traffics test: inner traffic : committed: 7926 txn/s, latency: 4947 ms, (p50: 4800 ms, p90: 5700 ms, p99: 10500 ms), latency samples: 3424420
two traffics test : committed: 100 txn/s, latency: 1983 ms, (p50: 1900 ms, p90: 2100 ms, p99: 6000 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.205, avg: 0.202", "QsPosToProposal: max: 0.243, avg: 0.234", "ConsensusProposalToOrdered: max: 0.449, avg: 0.421", "ConsensusOrderedToCommit: max: 0.392, avg: 0.375", "ConsensusProposalToCommit: max: 0.816, avg: 0.796"]
Max round gap was 1 [limit 4] at version 1633692. Max no progress secs was 4.591461 [limit 15] at version 1633692.
Test Ok
framework_upgrade
success on 01b24e7e3548382dd25440b39a0438a993387f12
==> 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0d4151ebe52ceeea579a9a4913e7518cb16d12d3 (PR)
Upgrade the nodes to version: 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1251 txn/s, submitted: 1253 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2473 ms, (p50: 2100 ms, p90: 4300 ms, p99: 5700 ms), latency samples: 111400
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1261 txn/s, submitted: 1264 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2479 ms, (p50: 2100 ms, p90: 4200 ms, p99: 6000 ms), latency samples: 114840
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0d4151ebe52ceeea579a9a4913e7518cb16d12d3 passed
Upgrade the remaining nodes to version: 0d4151ebe52ceeea579a9a4913e7518cb16d12d3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1261 txn/s, submitted: 1264 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2641 ms, (p50: 2100 ms, p90: 4500 ms, p99: 7200 ms), latency samples: 103480
Test Ok
Description
Handle empty vector constants by using
VecPack
instead ofLdConst
since the run-time vector constant doesn't have a type if it's empty.Fixes #13201.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Added tests showing the original bug, some simplified tests, and re-ran existing tests.
Key Areas to Review
Whatever
Checklist