[move] Remove mutref outputs & clean function loading

georgemitenkov commented 1 week ago

Description

This PR:

Removes mutref outputs from function execution, as they are not used by Aptos. Note that dummy_locals are still there because we allow passing &signer as an argument.
Shift entry function check to entry function where it belongs.
Unify function execution APIs, so that function is loaded first, and then its instantiation is executed.

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[x] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[x] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

Existing tests.

Key Areas to Review

Checklist

[x] I have read and followed the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 1 week ago

⏱️ 10h 41m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832869218) | 2h 10m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8972003556/job/24639033039) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8972009028/job/24639048589) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8973451863/job/24643665431) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9021054685/job/24787523782) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832869218) | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832869433) | 1h 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054685/job/24787523032) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832869433) | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/9036283222/job/24832854845) | 1h 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972003551/job/24639013501) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451869/job/24643652651) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283222/job/24832854845) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036283219/job/24832854953) | 1h 3m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8972003560/job/24639013812) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8972009016/job/24639035026) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451858/job/24643652712) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054662/job/24787509050) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283219/job/24832854953) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832871409) | 52m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009128/job/24639052017) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451880/job/24643665974) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24787523667) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832871409) | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/9036283259/job/24832993249) | 51m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8972009062/job/24639046043) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451886/job/24643662831) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283259/job/24832993249) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832868943) | 35m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8972003556/job/24639030695) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009028/job/24639048078) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451863/job/24643665054) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054685/job/24787522615) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832868943) | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833321558) | 31m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24788049336) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833321558) | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833321367) | 27m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24788048764) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833321367) | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833320961) | 18m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24788048538) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833320961) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/9036283054/job/24832871360) | 17m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009070/job/24639058586) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451812/job/24643669492) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054708/job/24787531256) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283054/job/24832871360) | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832869978) | 15m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054685/job/24787524082) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832869978) | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8973451880/job/24643659860) | 14m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009128/job/24639042740) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451880/job/24643659860) | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/9036283217/job/24832854763) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054668/job/24787508427) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283217/job/24832854763) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832869699) | 7m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8972003556/job/24639031129) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009028/job/24639047809) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451863/job/24643665258) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054685/job/24787523292) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832869699) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/9036283239/job/24832854251) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972003558/job/24639012171) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009023/job/24639031354) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451859/job/24643651727) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054674/job/24787507873) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283239/job/24832854251) | | [execution-performance / test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036283259/job/24832854967) | 7m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9021054683/job/24787508485) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283259/job/24832854967) | | [test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832865556) | 7m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24787516816) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832865556) | | [indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833320593) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24788048269) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833320593) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/9036283221/job/24832854257) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972003562/job/24639012715) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009018/job/24639031405) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451872/job/24643651816) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054671/job/24787507871) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283221/job/24832854257) | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833320800) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24788049564) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24833320800) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832855035) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972003556/job/24639014142) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009028/job/24639035270) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451863/job/24643652423) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054685/job/24787508428) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283226/job/24832855035) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036283054/job/24832859121) | 58s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972003391/job/24639021959) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009070/job/24639043482) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451812/job/24643657540) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054708/job/24787516730) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283054/job/24832859121) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832864321) | 46s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009128/job/24639042505) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451880/job/24643660456) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24787517100) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832864321) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036283061/job/24832853715) | 30s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972003398/job/24639011751) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009064/job/24639032929) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451806/job/24643652036) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054699/job/24787509102) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283061/job/24832853715) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036283060/job/24832853447) | 21s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972003393/job/24639011302) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009054/job/24639031654) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451809/job/24643651523) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054711/job/24787507882) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283060/job/24832853447) | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8973451886/job/24643652395) | 18s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009062/job/24639032710) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451886/job/24643652395) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036283066/job/24832853500) | 14s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972003388/job/24639011316) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009059/job/24639031650) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451808/job/24643651499) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054703/job/24787508016) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283066/job/24832853500) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832854286) | 12s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009128/job/24639033477) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451880/job/24643652921) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24787509544) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832854286) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9036283054/job/24832853652) | 12s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972003391/job/24639011689) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009070/job/24639035974) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451812/job/24643652101) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054708/job/24787508871) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283054/job/24832853652) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832865144) | 6s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8972009128/job/24639042119) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973451880/job/24643660168) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9021054745/job/24787516537) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9036283116/job/24832865144) |

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
rust-move-tests	16m	12m
rust-targeted-unit-tests	25m	19m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 58.62069% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 57.3%. Comparing base (247d2e1) to head (420e0a2). Report is 2 commits behind head on main.

Files	Patch %	Lines
aptos-move/aptos-vm/src/aptos_vm.rs	0.0%	9 Missing :warning:
...ty/move/tools/move-cli/src/sandbox/commands/run.rs	0.0%	6 Missing :warning:
...ove/extensions/async/move-async-vm/src/async_vm.rs	0.0%	5 Missing :warning:
third_party/move/move-vm/runtime/src/session.rs	82.6%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #13206 +/- ## ========================================= - Coverage 57.5% 57.3% -0.3% ========================================= Files 833 833 Lines 198661 198562 -99 ========================================= - Hits 114281 113782 -499 - Misses 84380 84780 +400 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

Forge is running suite `realistic_env_max_load` on `4e7f78e45fced659f164bc833d070336ba2787e8`

github-actions[bot] commented 1 week ago

Forge is running suite `compat` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `4e7f78e45fced659f164bc833d070336ba2787e8`

github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite `compat` success on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `4e7f78e45fced659f164bc833d070336ba2787e8`

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4e7f78e45fced659f164bc833d070336ba2787e8 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6720 txn/s, latency: 4970 ms, (p50: 4800 ms, p90: 8400 ms, p99: 10200 ms), latency samples: 235220
2. Upgrading first Validator to new version: 4e7f78e45fced659f164bc833d070336ba2787e8
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1763 txn/s, latency: 16349 ms, (p50: 19300 ms, p90: 22000 ms, p99: 22800 ms), latency samples: 91720
3. Upgrading rest of first batch to new version: 4e7f78e45fced659f164bc833d070336ba2787e8
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1705 txn/s, latency: 16875 ms, (p50: 19300 ms, p90: 25900 ms, p99: 26500 ms), latency samples: 81860
4. upgrading second batch to new version: 4e7f78e45fced659f164bc833d070336ba2787e8
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3358 txn/s, latency: 9358 ms, (p50: 9800 ms, p90: 15200 ms, p99: 17400 ms), latency samples: 134320
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4e7f78e45fced659f164bc833d070336ba2787e8 passed
Test Ok

github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite `realistic_env_max_load` success on `4e7f78e45fced659f164bc833d070336ba2787e8`

two traffics test: inner traffic : committed: 8148 txn/s, latency: 4810 ms, (p50: 4500 ms, p90: 5700 ms, p99: 9900 ms), latency samples: 3520320
two traffics test : committed: 100 txn/s, latency: 1888 ms, (p50: 1800 ms, p90: 2100 ms, p99: 2600 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.212, avg: 0.203", "QsPosToProposal: max: 0.228, avg: 0.217", "ConsensusProposalToOrdered: max: 0.445, avg: 0.412", "ConsensusOrderedToCommit: max: 0.384, avg: 0.369", "ConsensusProposalToCommit: max: 0.798, avg: 0.781"]
Max round gap was 1 [limit 4] at version 1641100. Max no progress secs was 4.890759 [limit 15] at version 1641100.
Test Ok

github-actions[bot] commented 1 week ago

Forge is running suite `compat` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `a34566967fc2c6edec825f7f8fb6e19b7f716662`

github-actions[bot] commented 1 week ago

Forge is running suite `realistic_env_max_load` on `a34566967fc2c6edec825f7f8fb6e19b7f716662`

github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite `compat` success on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `a34566967fc2c6edec825f7f8fb6e19b7f716662`

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a34566967fc2c6edec825f7f8fb6e19b7f716662 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6099.999797219693 txn/s, latency: 5265.973906505113 ms, (p50: 4800 ms, p90: 9900 ms, p99: 12100 ms), latency samples: 232740
2. Upgrading first Validator to new version: a34566967fc2c6edec825f7f8fb6e19b7f716662
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1820.6642013478076 txn/s, latency: 15817.242830842539 ms, (p50: 18400 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92340
3. Upgrading rest of first batch to new version: a34566967fc2c6edec825f7f8fb6e19b7f716662
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1831.2582955407102 txn/s, latency: 15636.273856423724 ms, (p50: 19400 ms, p90: 22200 ms, p99: 22800 ms), latency samples: 91380
4. upgrading second batch to new version: a34566967fc2c6edec825f7f8fb6e19b7f716662
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3008.6402092580433 txn/s, latency: 9813.585739987484 ms, (p50: 9900 ms, p90: 11600 ms, p99: 12500 ms), latency samples: 127840
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a34566967fc2c6edec825f7f8fb6e19b7f716662 passed
Test Ok

github-actions[bot] commented 1 week ago