[scripts] Fix libudev-devel package name for Fedora users - Githubissues

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.

https://aptosfoundation.org

Other

5.85k stars 3.54k forks source link

[scripts] Fix libudev-devel package name for Fedora users #13207

Open trwa opened 1 week ago

trwa commented 1 week ago

Description

In scripts/dev_setup.sh. Package libudev-dev is called libudev-devel on Fedora (dnf, yum).

Type of Change

[ ] New feature
[x] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[x] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[x] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

On a Fedora 40 system.

Before changes:

Script scripts/dev_setup.sh -yp fails.
Move prover tests fail.

After changes:

Script scripts/dev_setup.sh -yp succeeds.
Move prover tests succeed.

Key Areas to Review

Checklist

[x] I have read and followed the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I identified and added all stakeholders and component owners affected by this change as reviewers
[x] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 1 week ago

⏱️ 10s total CI duration on this PR

Job	Cumulative Duration	Recent Runs
permission-check	3s	🟥
permission-check	3s	🟥
permission-check	2s	🟥
permission-check	2s	🟥

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}