[quorum store] fix last commit in #13019

[bchocho]

Description

Accidentally landed #13019 with local changes not committed.

Type of Change

• [ ] New feature
• [x] Bug fix
• [ ] Breaking change
• [ ] Performance improvement
• [ ] Refactoring
• [ ] Dependency update
• [ ] Documentation update
• [ ] Tests

Which Components or Systems Does This Change Impact?

• [x] Validator Node
• [ ] Full Node (API, Indexer, etc.)
• [ ] Move/Aptos Virtual Machine
• [ ] Aptos Framework
• [ ] Aptos CLI/SDK
• [ ] Developer Infrastructure
• [ ] Other (specify)

How Has This Been Tested?

All CICD tests

Key Areas to Review

Checklist

• [ ] I have read and followed the CONTRIBUTING doc
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I identified and added all stakeholders and component owners affected by this change as reviewers
• [ ] I tested both happy and unhappy path of the functionality
• [ ] I have made corresponding changes to the documentation

[trunk-io[bot]]

⏱️ 7h 10m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8976167971/job/24653564108) | 1h 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106025/job/24642543507) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8976167971/job/24652423678) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167971/job/24653564108)  | | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652823071) | 1h 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652823071)  | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652423119) | 1h 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973105993/job/24642546505) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652423119)  | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/8976167973/job/24652411614) | 37m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167973/job/24652411614)  | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822906) | 32m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24643061723) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822906)  | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822543) | 27m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24643061930) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822543)  | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652426481) | 26m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24642549475) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652426481)  | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652422880) | 17m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973100233/job/24642531986) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973105993/job/24642547238) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652422880)  | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652422655) | 15m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973100233/job/24642530799) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973105993/job/24642546855) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652422655)  | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822385) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24643061211) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822385)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8976167965/job/24652412166) | 10m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973100228/job/24642517543) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973105990/job/24642536019) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167965/job/24652412166)  | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8976167970/job/24652427839) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106030/job/24642558768) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167970/job/24652427839)  | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652418784) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24642539580) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652418784)  | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/8976167968/job/24652412205) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973105995/job/24642531656) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167968/job/24652412205)  | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652423652) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973105993/job/24642545537) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652423652)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8976167966/job/24652411596) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973100224/job/24642515626) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106003/job/24642530611) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167966/job/24652411596)  | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652423384) | 4m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973100233/job/24642529992) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973105993/job/24642545889) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652423384)  | | [indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822058) | 3m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24643062208) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822058)  | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822204) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24643062436) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652822204)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8976167976/job/24652411624) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973100234/job/24642515739) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973105996/job/24642530510) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167976/job/24652411624)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652412309) | 31s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973100233/job/24642516914) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973105993/job/24642533611) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167964/job/24652412309)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8976167970/job/24652417072) | 29s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973100249/job/24642525696) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106030/job/24642543995) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167970/job/24652417072)  | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8976167971/job/24652412013) | 22s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106025/job/24642531496) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167971/job/24652412013)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652418992) | 20s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24642540317) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652418992)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8976167963/job/24652412527) | 13s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973100231/job/24642517126) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106035/job/24642531445) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167963/job/24652412527)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8976167974/job/24652411720) | 12s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973100237/job/24642515971) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106033/job/24642530711) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167974/job/24652411720)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8976167980/job/24652411742) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973100232/job/24642516295) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106031/job/24642530487) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167980/job/24652411742)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8976167970/job/24652412349) | 7s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973100249/job/24642516782) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106030/job/24642536405) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976167970/job/24652412349)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652412806) | 5s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24642532298) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652412806)  | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652419225) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973106096/job/24642539968) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976168007/job/24652419225)  |

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions[bot]]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite realistic_env_max_load on 43aeb1ea9b02040886048834f83f7ab79abfd5ed

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6537 txn/s, latency: 4926 ms, (p50: 4800 ms, p90: 8400 ms, p99: 10500 ms), latency samples: 241900
2. Upgrading first Validator to new version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1545 txn/s, latency: 18485 ms, (p50: 22400 ms, p90: 29800 ms, p99: 30200 ms), latency samples: 74180
3. Upgrading rest of first batch to new version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1710 txn/s, latency: 16530 ms, (p50: 19100 ms, p90: 23200 ms, p99: 23600 ms), latency samples: 90680
4. upgrading second batch to new version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3286 txn/s, latency: 9467 ms, (p50: 9900 ms, p90: 12300 ms, p99: 13600 ms), latency samples: 131460
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite realistic_env_max_load success on 43aeb1ea9b02040886048834f83f7ab79abfd5ed

two traffics test: inner traffic : committed: 8109 txn/s, latency: 4841 ms, (p50: 4500 ms, p90: 5700 ms, p99: 11100 ms), latency samples: 3495240
two traffics test : committed: 100 txn/s, latency: 1917 ms, (p50: 1900 ms, p90: 2200 ms, p99: 4400 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.202", "QsPosToProposal: max: 0.249, avg: 0.222", "ConsensusProposalToOrdered: max: 0.451, avg: 0.424", "ConsensusOrderedToCommit: max: 0.366, avg: 0.344", "ConsensusProposalToCommit: max: 0.789, avg: 0.768"]
Max round gap was 1 [limit 4] at version 1777052. Max no progress secs was 4.724326 [limit 15] at version 1777052.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite realistic_env_max_load on 43aeb1ea9b02040886048834f83f7ab79abfd5ed

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite framework_upgrade on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6514 txn/s, latency: 5093 ms, (p50: 4800 ms, p90: 8900 ms, p99: 10100 ms), latency samples: 228020
2. Upgrading first Validator to new version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1728 txn/s, latency: 17321 ms, (p50: 19000 ms, p90: 24400 ms, p99: 24700 ms), latency samples: 93320
3. Upgrading rest of first batch to new version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1648 txn/s, latency: 17185 ms, (p50: 19500 ms, p90: 22300 ms, p99: 22800 ms), latency samples: 85720
4. upgrading second batch to new version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3622 txn/s, latency: 8867 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12700 ms), latency samples: 144880
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite realistic_env_max_load success on 43aeb1ea9b02040886048834f83f7ab79abfd5ed

two traffics test: inner traffic : committed: 7320 txn/s, latency: 5362 ms, (p50: 5100 ms, p90: 6200 ms, p99: 12200 ms), latency samples: 3162560
two traffics test : committed: 100 txn/s, latency: 2085 ms, (p50: 2000 ms, p90: 2300 ms, p99: 6900 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.205, avg: 0.204", "QsPosToProposal: max: 0.280, avg: 0.256", "ConsensusProposalToOrdered: max: 0.472, avg: 0.444", "ConsensusOrderedToCommit: max: 0.395, avg: 0.383", "ConsensusProposalToCommit: max: 0.840, avg: 0.827"]
Max round gap was 1 [limit 4] at version 1525506. Max no progress secs was 4.651746 [limit 15] at version 1525506.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed (PR)
Upgrade the nodes to version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1368 txn/s, submitted: 1370 txn/s, failed submission: 1 txn/s, expired: 1 txn/s, latency: 2373 ms, (p50: 2100 ms, p90: 3900 ms, p99: 5400 ms), latency samples: 113620
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1219 txn/s, submitted: 1222 txn/s, failed submission: 3 txn/s, expired: 3 txn/s, latency: 2533 ms, (p50: 1800 ms, p90: 4700 ms, p99: 8100 ms), latency samples: 108500
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 43aeb1ea9b02040886048834f83f7ab79abfd5ed passed
Upgrade the remaining nodes to version: 43aeb1ea9b02040886048834f83f7ab79abfd5ed
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1189 txn/s, submitted: 1193 txn/s, failed submission: 3 txn/s, expired: 3 txn/s, latency: 2518 ms, (p50: 2100 ms, p90: 4400 ms, p99: 6800 ms), latency samples: 105900
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking