search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
5.85k stars 3.54k forks source link

revert unintended txn max size change #13209

Closed zjma closed 1 week ago

zjma commented 1 week ago

Description

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

trunk-io[bot] commented 1 week ago
⏱️ 7h 2m total CI duration on this PR | Job | Cumulative Duration | Recent Runs | |---|---|---| | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656904649) | 2h 26m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583910/job/24644844454) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656904649)  | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/8977559331/job/24656528479) | 43m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559331/job/24656528479)  | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656537896) | 42m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583664/job/24644121685) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656537896)  | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656538017) | 32m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656538017)  | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656538472) | 30m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583910/job/24644121931) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656538472)  | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8977559356/job/24656539316) | 23m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559356/job/24656539316)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977559320/job/24656529339) | 18m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973581374/job/24644097049) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8973583624/job/24644107177) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559320/job/24656529339)  | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656537600) | 17m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583664/job/24644121091) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656537600)  | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656904511) | 14m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656904511)  | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656904159) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656904159)  | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8977559352/job/24656542901) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583785/job/24644127953) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559352/job/24656542901)  | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656534862) | 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583910/job/24644115786) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656534862)  | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656903832) | 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656903832)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8977559326/job/24656528229) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973581381/job/24644095829) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583616/job/24644101391) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559326/job/24656528229)  | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656537732) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656537732)  | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/8977559334/job/24656529063) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559334/job/24656529063)  | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656537414) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583664/job/24644121456) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656537414)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8977559341/job/24656528271) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973581370/job/24644095848) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583619/job/24644101842) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559341/job/24656528271)  | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656904355) | 52s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656904355)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656529217) | 25s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973581380/job/24644096855) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583664/job/24644108188) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559340/job/24656529217)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656534648) | 24s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583910/job/24644115473) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656534648)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977559352/job/24656534299) | 23s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583785/job/24644116190) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559352/job/24656534299)  | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977559356/job/24656529141) | 14s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559356/job/24656529141)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977559345/job/24656529080) | 12s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973581247/job/24644095511) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583801/job/24644106559) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559345/job/24656529080)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977559337/job/24656528289) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973581252/job/24644095231) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583806/job/24644103127) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559337/job/24656528289)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977559346/job/24656528597) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973581263/job/24644095157) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583817/job/24644103293) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559346/job/24656528597)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656529676) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583910/job/24644104447) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656529676)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977559352/job/24656528925) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973581253/job/24644095573) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583785/job/24644107640) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559352/job/24656528925)  | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656535009) | 3s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973583910/job/24644116051) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977559406/job/24656535009)  |

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 16m 9m +92%
run-tests-main-branch 6m 4m +30%
windows-build 43m 36m +21%
framework-upgrade-determinator 3m 4m -29%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

github-actions[bot] commented 1 week ago

Forge is running suite framework_upgrade on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e

github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e (PR)
Upgrade the nodes to version: 07cff717eff321cf7b2b901f5433ff50929a197e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1170 txn/s, submitted: 1172 txn/s, failed submission: 1 txn/s, expired: 1 txn/s, latency: 2843 ms, (p50: 2100 ms, p90: 5200 ms, p99: 8100 ms), latency samples: 95960
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1309 txn/s, submitted: 1310 txn/s, failed submission: 1 txn/s, expired: 1 txn/s, latency: 2774 ms, (p50: 2100 ms, p90: 5000 ms, p99: 8100 ms), latency samples: 107340
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e passed
Upgrade the remaining nodes to version: 07cff717eff321cf7b2b901f5433ff50929a197e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1120 txn/s, submitted: 1122 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2797 ms, (p50: 2400 ms, p90: 4500 ms, p99: 6900 ms), latency samples: 97440
Test Ok
github-actions[bot] commented 1 week ago

Forge is running suite realistic_env_max_load on 07cff717eff321cf7b2b901f5433ff50929a197e

github-actions[bot] commented 1 week ago

Forge is running suite framework_upgrade on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e

github-actions[bot] commented 1 week ago

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e

github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite realistic_env_max_load success on 07cff717eff321cf7b2b901f5433ff50929a197e

two traffics test: inner traffic : committed: 8340 txn/s, latency: 4711 ms, (p50: 4500 ms, p90: 5500 ms, p99: 10200 ms), latency samples: 3594900
two traffics test : committed: 100 txn/s, latency: 1951 ms, (p50: 1900 ms, p90: 2200 ms, p99: 4900 ms), latency samples: 1640
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.206, avg: 0.204", "QsPosToProposal: max: 0.230, avg: 0.208", "ConsensusProposalToOrdered: max: 0.454, avg: 0.425", "ConsensusOrderedToCommit: max: 0.384, avg: 0.367", "ConsensusProposalToCommit: max: 0.808, avg: 0.792"]
Max round gap was 1 [limit 4] at version 1811417. Max no progress secs was 5.171591 [limit 15] at version 1811417.
Test Ok
github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5782 txn/s, latency: 5231 ms, (p50: 5000 ms, p90: 8700 ms, p99: 10900 ms), latency samples: 248660
2. Upgrading first Validator to new version: 07cff717eff321cf7b2b901f5433ff50929a197e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1561 txn/s, latency: 15852 ms, (p50: 18700 ms, p90: 21900 ms, p99: 23600 ms), latency samples: 89020
3. Upgrading rest of first batch to new version: 07cff717eff321cf7b2b901f5433ff50929a197e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1713 txn/s, latency: 16833 ms, (p50: 19300 ms, p90: 22400 ms, p99: 22900 ms), latency samples: 89080
4. upgrading second batch to new version: 07cff717eff321cf7b2b901f5433ff50929a197e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3604 txn/s, latency: 8780 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12700 ms), latency samples: 144180
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e passed
Test Ok
github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e (PR)
Upgrade the nodes to version: 07cff717eff321cf7b2b901f5433ff50929a197e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1334 txn/s, submitted: 1337 txn/s, failed submission: 3 txn/s, expired: 3 txn/s, latency: 2281 ms, (p50: 2100 ms, p90: 3900 ms, p99: 5100 ms), latency samples: 120060
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1316 txn/s, submitted: 1319 txn/s, failed submission: 3 txn/s, expired: 3 txn/s, latency: 2385 ms, (p50: 2000 ms, p90: 4200 ms, p99: 5400 ms), latency samples: 114500
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 07cff717eff321cf7b2b901f5433ff50929a197e passed
Upgrade the remaining nodes to version: 07cff717eff321cf7b2b901f5433ff50929a197e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1131 txn/s, submitted: 1133 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2739 ms, (p50: 2300 ms, p90: 4700 ms, p99: 7500 ms), latency samples: 100660
Test Ok