search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
5.85k stars 3.54k forks source link

[gas] remove unintended change to max_transaction_size_in_bytes (1.11) #13211

Closed vgao1996 closed 1 week ago

trunk-io[bot] commented 1 week ago
⏱️ 6h 40m total CI duration on this PR | Job | Cumulative Duration | Recent Runs | |---|---|---| | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656992082) | 2h 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839892/job/24645569639) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656992082)  | | [rust-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656518076) | 58m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973820427/job/24644836862) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839842/job/24644905698) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656518076)  | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656517930) | 35m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656517930)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977550673/job/24656515993) | 35m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973820436/job/24644832198) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839843/job/24644906036) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550673/job/24656515993)  | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656516523) | 33m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839892/job/24644895027) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656516523)  | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8977550690/job/24656516456) | 24m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550690/job/24656516456)  | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656517567) | 17m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973820427/job/24644836614) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839842/job/24644905458) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656517567)  | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656991951) | 15m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656991951)  | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656991819) | 14m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656991819)  | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8977550708/job/24656522885) | 10m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973820350/job/24644840318) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839864/job/24644916579) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550708/job/24656522885)  | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656991397) | 9m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656991397)  | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656517700) | 5m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8973820427/job/24644836242) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839842/job/24644905163) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656517700)  | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/8977550675/job/24656505943) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550675/job/24656505943)  | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656518183) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656518183)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8977550671/job/24656505267) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973820440/job/24644818140) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839852/job/24644878835) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550671/job/24656505267)  | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/8977550683/job/24656505215) | 4m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8977550683/job/24656505215)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8977550691/job/24656504927) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973820426/job/24644817893) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839847/job/24644878625) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550691/job/24656504927)  | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656991552) | 50s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656991552)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656505983) | 43s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973820427/job/24644818547) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839842/job/24644892978) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550684/job/24656505983)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977550708/job/24656511942) | 39s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973820350/job/24644826457) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839864/job/24644903847) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550708/job/24656511942)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977550673/job/24656505813) | 36s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973820436/job/24644818893) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839843/job/24644893272) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550673/job/24656505813)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656512484) | 27s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839892/job/24644886584) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656512484)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977550708/job/24656505788) | 16s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973820350/job/24644817905) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839864/job/24644893768) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550708/job/24656505788)  | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8977550690/job/24656505491) | 14s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550690/job/24656505491)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977550711/job/24656505735) | 11s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973820349/job/24644818099) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839870/job/24644879576) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550711/job/24656505735)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977550716/job/24656505045) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973820351/job/24644817512) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839863/job/24644878667) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550716/job/24656505045)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977550723/job/24656505280) | 7s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973820358/job/24644817520) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839868/job/24644878619) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550723/job/24656505280)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656506447) | 5s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839892/job/24644880090) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656506447)  | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656512312) | 3s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8973839892/job/24644886967) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8977550803/job/24656512312)  |

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 14m 8m +70%
cli-e2e-tests / run-cli-tests 9m 6m +45%
rust-images / rust-all 17m 13m +28%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

github-actions[bot] commented 1 week ago

Forge is running suite framework_upgrade on aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6

github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite framework_upgrade success on aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6

Compatibility test results for aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6 (PR)
Upgrade the nodes to version: e595ef393f02fe99b41fac40198df66d48c907e6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 6686 txn/s, latency: 4972 ms, (p50: 4800 ms, p90: 8400 ms, p99: 10000 ms), latency samples: 234040
5. check swarm health
Compatibility test for aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6 passed
Test Ok
github-actions[bot] commented 1 week ago

Forge is running suite framework_upgrade on aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6

github-actions[bot] commented 1 week ago

Forge is running suite compat on aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6

github-actions[bot] commented 1 week ago

Forge is running suite realistic_env_max_load on e595ef393f02fe99b41fac40198df66d48c907e6

github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite compat success on aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6

Compatibility test results for aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6 (PR)
1. Check liveness of validators at old version: aptos-node-v1.10.1
compatibility::simple-validator-upgrade::liveness-check : committed: 6934 txn/s, latency: 4787 ms, (p50: 4800 ms, p90: 7600 ms, p99: 8200 ms), latency samples: 242720
2. Upgrading first Validator to new version: e595ef393f02fe99b41fac40198df66d48c907e6
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1750 txn/s, latency: 16756 ms, (p50: 18900 ms, p90: 23300 ms, p99: 23500 ms), latency samples: 92800
3. Upgrading rest of first batch to new version: e595ef393f02fe99b41fac40198df66d48c907e6
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1837 txn/s, latency: 15823 ms, (p50: 18800 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 91880
4. upgrading second batch to new version: e595ef393f02fe99b41fac40198df66d48c907e6
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2348 txn/s, latency: 11035 ms, (p50: 9900 ms, p90: 14000 ms, p99: 15300 ms), latency samples: 115080
5. check swarm health
Compatibility test for aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6 passed
Test Ok
github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite realistic_env_max_load success on e595ef393f02fe99b41fac40198df66d48c907e6

two traffics test: inner traffic : committed: 7748 txn/s, latency: 5058 ms, (p50: 4800 ms, p90: 6000 ms, p99: 13800 ms), latency samples: 3347260
two traffics test : committed: 100 txn/s, latency: 2111 ms, (p50: 1800 ms, p90: 2200 ms, p99: 11200 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.274, avg: 0.213", "QsPosToProposal: max: 0.229, avg: 0.201", "ConsensusProposalToOrdered: max: 0.451, avg: 0.423", "ConsensusOrderedToCommit: max: 0.411, avg: 0.392", "ConsensusProposalToCommit: max: 0.834, avg: 0.814"]
Max round gap was 2 [limit 4] at version 1615235. Max no progress secs was 9.495939 [limit 15] at version 1615235.
Test Ok
github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite framework_upgrade success on aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6

Compatibility test results for aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6 (PR)
Upgrade the nodes to version: e595ef393f02fe99b41fac40198df66d48c907e6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 5962 txn/s, latency: 5248 ms, (p50: 4800 ms, p90: 9300 ms, p99: 15900 ms), latency samples: 226560
5. check swarm health
Compatibility test for aptos-node-v1.10.1 ==> e595ef393f02fe99b41fac40198df66d48c907e6 passed
Test Ok