validate txn size liimt change

zjma commented 1 week ago

Description

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

[ ] I have read and followed the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 1 week ago

⏱️ 2h 18m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651778095) | 49m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651778095) | | [rust-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8975765761/job/24651152804) | 31m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765761/job/24651152804) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8975765763/job/24651148795) | 19m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765763/job/24651148795) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651148218) | 16m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651148218) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8975765761/job/24651152529) | 11m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765761/job/24651152529) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8975765787/job/24651158070) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765787/job/24651158070) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8975761303/job/24651120846) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765755/job/24651132186) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975761303/job/24651120846) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8975765761/job/24651152270) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765761/job/24651152270) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8975765768/job/24651132500) | 51s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975761295/job/24651120851) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765768/job/24651132500) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8975765763/job/24651136263) | 25s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975761294/job/24651121459) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765763/job/24651136263) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8975765761/job/24651137991) | 25s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8975761298/job/24651121455) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765761/job/24651137991) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8975765787/job/24651145400) | 18s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8975761081/job/24651126901) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765787/job/24651145400) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651142720) | 13s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651142720) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8975765787/job/24651136019) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975761081/job/24651120235) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765787/job/24651136019) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8975765792/job/24651132754) | 6s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975761082/job/24651119947) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765792/job/24651132754) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651134196) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651134196) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8975765801/job/24651133734) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975761083/job/24651120222) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765801/job/24651133734) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8975765798/job/24651132592) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975761086/job/24651120018) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765798/job/24651132592) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651142503) | 2s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8975765918/job/24651142503) |

🚨 3 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg
rust-move-tests	19m	8m
rust-lints	11m	6m
rust-images / rust-all	16m	13m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

github-actions[bot] commented 1 week ago

Forge is running suite `framework_upgrade` on `fc8acd78dd210d270f932cdc1c4f95971086876f` ==> `0be9e9595d87abbdc628f3faa2a4d9ea31abf913`

github-actions[bot] commented 1 week ago

:x: Forge suite `framework_upgrade` failure on `fc8acd78dd210d270f932cdc1c4f95971086876f` ==> `0be9e9595d87abbdc628f3faa2a4d9ea31abf913`

Compatibility test results for fc8acd78dd210d270f932cdc1c4f95971086876f ==> 0be9e9595d87abbdc628f3faa2a4d9ea31abf913 (PR)
Upgrade the nodes to version: 0be9e9595d87abbdc628f3faa2a4d9ea31abf913
Test Failed: API error: Unknown error Transaction committed on chain, but failed execution: Move abort in 0x1::gas_schedule: EINVALID_GAS_FEATURE_VERSION(0x10002): 

Stack backtrace:
   0: anyhow::error::<impl core::convert::From<E> for anyhow::Error>::from
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.79/src/error.rs:565:25
   1: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/result.rs:1963:27
   2: aptos_release_builder::validate::NetworkConfig::execute_proposal::{{closure}}
             at ./aptos-move/aptos-release-builder/src/validate.rs:364:9
   3: aptos_release_builder::validate::NetworkConfig::submit_and_execute_multi_step_proposal::{{closure}}
             at ./aptos-move/aptos-release-builder/src/validate.rs:124:64
   4: aptos_release_builder::validate::execute_release::{{closure}}
             at ./aptos-move/aptos-release-builder/src/validate.rs:432:22
   5: aptos_release_builder::validate::validate_config_and_generate_release::{{closure}}
             at ./aptos-move/aptos-release-builder/src/validate.rs:493:6
   6: aptos_release_builder::validate::validate_config::{{closure}}
             at ./aptos-move/aptos-release-builder/src/validate.rs:479:80
   7: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/park.rs:282:63
   8: tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/coop.rs:107:5
   9: tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/coop.rs:73:5
  10: tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/park.rs:282:31
  11: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/context/blocking.rs:66:9
  12: tokio::runtime::scheduler::multi_thread::MultiThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/scheduler/multi_thread/mod.rs:87:13
  13: tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/context/runtime.rs:65:16
  14: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/scheduler/multi_thread/mod.rs:86:9
  15: tokio::runtime::runtime::Runtime::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/runtime.rs:350:50
  16: <aptos_testcases::framework_upgrade::FrameworkUpgrade as aptos_forge::interface::network::NetworkTest>::run
             at ./testsuite/testcases/src/framework_upgrade.rs:97:9
  17: aptos_forge::runner::Forge<F>::run::{{closure}}
             at ./testsuite/forge/src/runner.rs:598:42
  18: aptos_forge::runner::run_test
             at ./testsuite/forge/src/runner.rs:666:11
  19: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:598:30
  20: forge::run_forge
             at ./testsuite/forge-cli/src/main.rs:427:11
  21: forge::main
             at ./testsuite/forge-cli/src/main.rs:353:21
  22: core::ops::function::FnOnce::call_once
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/ops/function.rs:250:5
  23: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/sys_common/backtrace.rs:154:18
  24: std::rt::lang_start::{{closure}}
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:167:18
  25: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/ops/function.rs:284:13
  26: std::panicking::try::do_call
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:552:40
  27: std::panicking::try
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:516:19
  28: std::panic::catch_unwind
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panic.rs:142:14
  29: std::rt::lang_start_internal::{{closure}}
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:148:48
  30: std::panicking::try::do_call
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:552:40
  31: std::panicking::try
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:516:19
  32: std::panic::catch_unwind
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panic.rs:142:14
  33: std::rt::lang_start_internal
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:148:20
  34: std::rt::lang_start
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:166:17
  35: __libc_start_main
  36: _start
Trailing Log Lines:
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:516:19
  32: std::panic::catch_unwind
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panic.rs:142:14
  33: std::rt::lang_start_internal
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:148:20
  34: std::rt::lang_start
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:166:17
  35: __libc_start_main
  36: _start

Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:292"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-13214-1715030633-fc8acd78dd210d270f9","timestamp":"2024-05-06T22:10:40.404483Z","message":"Deleting namespace forge-framework-upgrade-pr-13214: Some(NamespaceStatus { conditions: None, phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:400"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-13214-1715030633-fc8acd78dd210d270f9","timestamp":"2024-05-06T22:10:40.404514Z","message":"aptos-node resources for Forge removed in namespace: forge-framework-upgrade-pr-13214"}
Failed to run tests:
Tests Failed

failures:
    framework_upgrade::framework-upgrade

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Error: Tests Failed

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.79/src/error.rs:83:36
   1: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:618:13
   2: forge::run_forge
             at ./testsuite/forge-cli/src/main.rs:427:11
   3: forge::main
             at ./testsuite/forge-cli/src/main.rs:353:21
   4: core::ops::function::FnOnce::call_once
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/ops/function.rs:250:5
   5: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/sys_common/backtrace.rs:154:18
   6: std::rt::lang_start::{{closure}}
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:167:18
   7: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/ops/function.rs:284:13
   8: std::panicking::try::do_call
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:552:40
   9: std::panicking::try
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:516:19
  10: std::panic::catch_unwind
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panic.rs:142:14
  11: std::rt::lang_start_internal::{{closure}}
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:148:48
  12: std::panicking::try::do_call
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:552:40
  13: std::panicking::try
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:516:19
  14: std::panic::catch_unwind
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panic.rs:142:14
  15: std::rt::lang_start_internal
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:148:20
  16: std::rt::lang_start
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:166:17
  17: __libc_start_main
  18: _start
Debugging output:
NAME                       READY   STATUS    RESTARTS   AGE
aptos-node-0-validator-0   1/1     Running   0          43m
aptos-node-1-validator-0   1/1     Running   0          42m
aptos-node-2-validator-0   1/1     Running   0          41m
aptos-node-3-validator-0   1/1     Running   0          41m

aptos-labs / aptos-core