Create token with collection object.

JohnChangUK commented 1 week ago

Description

Amend create token functions which take in Object<Collection> to create tokens using the Object<Collection> rather than the collection name.

If the collection name is changed, the token creation will fail as the current token creation implementation still generates the collection with collection_name.
To circumvent this, a new function which directly creates tokens from the Object<Collection> is added.

Extra documentation will be added to the set_name function in collection.move, and the current token creation functions which take in collection_name.

Type of Change

[ ] New feature
[X] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[X] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

Unit tests added.

Checklist

[X] I have read and followed the CONTRIBUTING doc
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I identified and added all stakeholders and component owners affected by this change as reviewers
[X] I tested both happy and unhappy path of the functionality
[X] I have made corresponding changes to the documentation

trunk-io[bot] commented 1 week ago

⏱️ 6h 9m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/9054319046/job/24874036461) | 1h 55m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293359/job/24652836978) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8992319089/job/24701868497) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156947/job/24707208331) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107797/job/24742869310) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054319046/job/24874036461) | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9054319054/job/24874039650) | 1h 49m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293358/job/24652848051) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8992319096/job/24701881140) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156927/job/24707218770) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107794/job/24742882686) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054319054/job/24874039650) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9054319061/job/24874036741) | 1h 16m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293350/job/24652837126) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8992319113/job/24701868475) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156926/job/24707208037) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107799/job/24742868797) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054319061/job/24874036741) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9054319054/job/24874039567) | 36m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293358/job/24652847735) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156927/job/24707218598) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107794/job/24742882243) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054319054/job/24874039567) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/9054318865/job/24874042193) | 17m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293360/job/24652851310) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156877/job/24707221465) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107316/job/24742884771) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054318865/job/24874042193) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9054319054/job/24874039500) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293358/job/24652847910) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156927/job/24707218410) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107794/job/24742882490) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054319054/job/24874039500) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/9054319053/job/24874036118) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293349/job/24652836357) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156929/job/24707207274) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107792/job/24742867768) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054319053/job/24874036118) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/9054319048/job/24874036119) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293356/job/24652836325) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156934/job/24707207330) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107784/job/24742868130) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054319048/job/24874036119) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9054319054/job/24874036595) | 46s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293358/job/24652837168) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156927/job/24707207863) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107794/job/24742869068) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054319054/job/24874036595) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9054318865/job/24874038196) | 44s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293360/job/24652841403) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156877/job/24707213833) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107316/job/24742874021) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054318865/job/24874038196) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9054318862/job/24874035853) | 11s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293364/job/24652836849) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156890/job/24707207948) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107312/job/24742866069) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054318862/job/24874035853) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9054318865/job/24874035867) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293360/job/24652837379) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156877/job/24707208154) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107316/job/24742866129) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054318865/job/24874035867) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9054318861/job/24874035652) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293354/job/24652836579) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156885/job/24707207213) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107306/job/24742865891) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054318861/job/24874035652) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9054318863/job/24874035631) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8976293363/job/24652836549) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8994156883/job/24707207406) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9006107307/job/24742865878) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9054318863/job/24874035631) |

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
rust-targeted-unit-tests	26m	21m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.6%. Comparing base (6cdd4c2) to head (b2a5b39). Report is 4 commits behind head on main.

:exclamation: Current head b2a5b39 differs from pull request most recent head b46bd57. Consider uploading reports for the commit b46bd57 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #13215 +/- ## ======================================= Coverage 57.6% 57.6% ======================================= Files 834 834 Lines 198397 198397 ======================================= Hits 114318 114318 Misses 84079 84079 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.