Jmt internal node children as a sorted slice instead of hashmap

msmouse commented 3 weeks ago

Description

binary search to look up
cheaper clone, less mem allocation

about 3% improvement on average on the single node performance test.

Type of Change

[x] Performance improvement

Which Components or Systems Does This Change Impact?

[x] Validator Node

How Has This Been Tested?

existing coverage

Key Areas to Review

Checklist

[x] I have read and followed the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 3 weeks ago

⏱️ 22h 18m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982241080) | 3h 29m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445102/job/24919016825) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9070334886/job/24921908819) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447324/job/24922275195) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941513/job/24923711301) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982241080) (+9 more) | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/9090062956/job/24982294318) | 3h 28m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9070447329/job/24922381293) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9070941541/job/24923798838) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941541/job/24982078163) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062990/job/24982291495) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062956/job/24982294318) (+3 more) | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982240794) | 2h 15m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445102/job/24919016581) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9070334886/job/24921908605) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447324/job/24922274941) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941513/job/24923711534) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982240794) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9090062986/job/24982234093) | 1h 55m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445093/job/24919003718) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9070334894/job/24921899671) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447316/job/24922266038) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941526/job/24923702575) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062986/job/24982234093) (+9 more) | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/9090062979/job/24982233094) | 1h 20m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062928/job/24982232689) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062979/job/24982233094) | | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982483510) | 1h 16m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982483510) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/9090062914/job/24982247054) | 1h 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334826/job/24921911913) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447160/job/24922273219) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941435/job/24923713536) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033450/job/24982167473) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062914/job/24982247054) (+10 more) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982248573) | 1h 4m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9070334861/job/24921910682) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922280688) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24923712390) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9090033524/job/24982169328) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982248573) (+1 more) | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982483392) | 55m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445150/job/24919478869) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922672801) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24924084901) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982483392) | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982483275) | 53m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445150/job/24919479799) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922672672) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24924085012) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982483275) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982240653) | 53m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445102/job/24919015749) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9070334886/job/24921908020) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447324/job/24922274432) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941513/job/24923710976) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982240653) (+9 more) | | [single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/9045434022/job/24855209226) | 35m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9045434022/job/24855209226) | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982482704) | 33m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9069445150/job/24919478644) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922672205) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24924084631) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982482704) | | [execution-performance / test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9090062956/job/24982233273) | 25m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334904/job/24921899421) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447329/job/24922257204) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941541/job/24923702518) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062990/job/24982233382) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062956/job/24982233273) (+2 more) | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982241318) | 21m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445102/job/24919016330) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334886/job/24921908201) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447324/job/24922275660) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941513/job/24923711785) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982241318) | | [test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982245187) | 20m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334861/job/24921905433) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922275564) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24923708158) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033524/job/24982165084) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982245187) (+1 more) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/9090062925/job/24982232582) | 20m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334887/job/24921898955) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447322/job/24922256798) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941535/job/24923702140) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062965/job/24982233002) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062925/job/24982232582) (+10 more) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982240435) | 20m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445102/job/24919015395) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334886/job/24921907828) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447324/job/24922274741) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941513/job/24923711160) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982240435) (+9 more) | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/9090062968/job/24982233868) | 20m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445089/job/24919004111) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334892/job/24921899385) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447314/job/24922257243) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941533/job/24923702747) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062968/job/24982233868) | | [indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982483005) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445150/job/24919479119) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922672525) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24924085113) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982483005) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/9090062970/job/24982232874) | 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334895/job/24921899054) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447318/job/24922256782) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941515/job/24923702151) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062938/job/24982232681) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062970/job/24982232874) (+10 more) | | [test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9045434022/job/24855172284) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9045434022/job/24855172284) | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982482863) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445150/job/24919479590) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922672937) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24924085219) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982482863) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9090062914/job/24982241551) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334826/job/24921903679) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447160/job/24922260675) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941435/job/24923706067) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033450/job/24982161713) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062914/job/24982241551) (+10 more) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982234291) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9069445102/job/24919004214) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334886/job/24921899596) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447324/job/24922266599) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941513/job/24923702427) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062963/job/24982234291) (+9 more) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982245310) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334861/job/24921905230) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922275365) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24923708314) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033524/job/24982164982) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982245310) (+1 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9090062918/job/24982232578) | 50s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447164/job/24922255997) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941394/job/24923701533) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033447/job/24982157850) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062817/job/24982231992) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062918/job/24982232578) (+11 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9090062912/job/24982232573) | 48s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447165/job/24922256005) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941428/job/24923701576) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033455/job/24982157817) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062824/job/24982232046) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062912/job/24982232573) (+10 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9090062908/job/24982237227) | 43s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447168/job/24922256189) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941404/job/24923701920) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033451/job/24982158058) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9090062813/job/24982232059) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062908/job/24982237227) (+10 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9090062914/job/24982238050) | 42s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447160/job/24922256164) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941435/job/24923701846) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033450/job/24982158059) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9090062819/job/24982232329) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062914/job/24982238050) (+11 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982240409) | 19s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334861/job/24921899728) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922270597) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24923702551) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033524/job/24982158343) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982240409) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982245091) | 11s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070334861/job/24921905576) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070447193/job/24922275119) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070941476/job/24923707935) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090033524/job/24982164868) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9090062959/job/24982245091) (+1 more) |

🚨 3 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg
cli-e2e-tests / run-cli-tests	9m	7m
rust-targeted-unit-tests	23m	18m
rust-lints	5m	7m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

github-actions[bot] commented 2 weeks ago

Forge is running suite `compat` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `ae1737ea3b60c2524f1260c60d28535ee2b70e15`

github-actions[bot] commented 2 weeks ago

Forge is running suite `realistic_env_max_load` on `ae1737ea3b60c2524f1260c60d28535ee2b70e15`

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `compat` success on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `ae1737ea3b60c2524f1260c60d28535ee2b70e15`

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> ae1737ea3b60c2524f1260c60d28535ee2b70e15 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5276 txn/s, latency: 5410 ms, (p50: 4800 ms, p90: 8500 ms, p99: 11700 ms), latency samples: 232180
2. Upgrading first Validator to new version: ae1737ea3b60c2524f1260c60d28535ee2b70e15
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1510 txn/s, latency: 17380 ms, (p50: 18700 ms, p90: 30700 ms, p99: 31200 ms), latency samples: 92120
3. Upgrading rest of first batch to new version: ae1737ea3b60c2524f1260c60d28535ee2b70e15
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1701 txn/s, latency: 16392 ms, (p50: 19300 ms, p90: 24100 ms, p99: 25000 ms), latency samples: 91880
4. upgrading second batch to new version: ae1737ea3b60c2524f1260c60d28535ee2b70e15
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3438 txn/s, latency: 9099 ms, (p50: 9900 ms, p90: 12200 ms, p99: 13000 ms), latency samples: 137520
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> ae1737ea3b60c2524f1260c60d28535ee2b70e15 passed
Test Ok

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `realistic_env_max_load` success on `ae1737ea3b60c2524f1260c60d28535ee2b70e15`

two traffics test: inner traffic : committed: 7865 txn/s, latency: 4983 ms, (p50: 4800 ms, p90: 5700 ms, p99: 10200 ms), latency samples: 3398060
two traffics test : committed: 100 txn/s, latency: 1802 ms, (p50: 1800 ms, p90: 2000 ms, p99: 2200 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.214, avg: 0.202", "QsPosToProposal: max: 0.250, avg: 0.238", "ConsensusProposalToOrdered: max: 0.460, avg: 0.414", "ConsensusOrderedToCommit: max: 0.367, avg: 0.356", "ConsensusProposalToCommit: max: 0.778, avg: 0.770"]
Max round gap was 1 [limit 4] at version 1656808. Max no progress secs was 4.86933 [limit 15] at version 1656808.
Test Ok

github-actions[bot] commented 2 weeks ago

Forge is running suite `realistic_env_max_load` on `0b70678a2b43906108850fd58c8707fda5b910ca`

github-actions[bot] commented 2 weeks ago

Forge is running suite `compat` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `0b70678a2b43906108850fd58c8707fda5b910ca`

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `compat` success on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `0b70678a2b43906108850fd58c8707fda5b910ca`

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b70678a2b43906108850fd58c8707fda5b910ca (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6626.8670395278305 txn/s, latency: 4973.796083819993 ms, (p50: 4800 ms, p90: 8400 ms, p99: 9900 ms), latency samples: 232880
2. Upgrading first Validator to new version: 0b70678a2b43906108850fd58c8707fda5b910ca
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1821.907704276195 txn/s, latency: 15697.521211790394 ms, (p50: 18400 ms, p90: 22200 ms, p99: 22800 ms), latency samples: 91600
3. Upgrading rest of first batch to new version: 0b70678a2b43906108850fd58c8707fda5b910ca
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1576.1386972112402 txn/s, latency: 16705.284734320558 ms, (p50: 19300 ms, p90: 26800 ms, p99: 28600 ms), latency samples: 91840
4. upgrading second batch to new version: 0b70678a2b43906108850fd58c8707fda5b910ca
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3581.431188453236 txn/s, latency: 8765.229129711752 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12800 ms), latency samples: 144320
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b70678a2b43906108850fd58c8707fda5b910ca passed
Test Ok

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `realistic_env_max_load` success on `0b70678a2b43906108850fd58c8707fda5b910ca`

two traffics test: inner traffic : committed: 8139.58434612306 txn/s, latency: 4800.049334001314 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10500 ms), latency samples: 3533040
two traffics test : committed: 99.97055984467882 txn/s, latency: 1896.0258426966293 ms, (p50: 1800 ms, p90: 2200 ms, p99: 3200 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.203", "QsPosToProposal: max: 0.242, avg: 0.222", "ConsensusProposalToOrdered: max: 0.437, avg: 0.417", "ConsensusOrderedToCommit: max: 0.387, avg: 0.369", "ConsensusProposalToCommit: max: 0.801, avg: 0.786"]
Max round gap was 1 [limit 4] at version 1745359. Max no progress secs was 4.795982 [limit 15] at version 1745359.
Test Ok

github-actions[bot] commented 2 weeks ago

Forge is running suite `realistic_env_max_load` on `82fbf8d5eee7434b87b4582caed35f69ffdec534`

github-actions[bot] commented 2 weeks ago

Forge is running suite `compat` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `82fbf8d5eee7434b87b4582caed35f69ffdec534`

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `realistic_env_max_load` success on `82fbf8d5eee7434b87b4582caed35f69ffdec534`

two traffics test: inner traffic : committed: 8041.463912398282 txn/s, latency: 4875.29511079552 ms, (p50: 4500 ms, p90: 5700 ms, p99: 12900 ms), latency samples: 3478480
two traffics test : committed: 99.99053240183957 txn/s, latency: 1957.702808988764 ms, (p50: 1800 ms, p90: 2100 ms, p99: 9300 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.202", "QsPosToProposal: max: 0.334, avg: 0.249", "ConsensusProposalToOrdered: max: 0.451, avg: 0.414", "ConsensusOrderedToCommit: max: 0.400, avg: 0.363", "ConsensusProposalToCommit: max: 0.840, avg: 0.776"]
Max round gap was 1 [limit 4] at version 1826776. Max no progress secs was 4.822419 [limit 15] at version 1826776.
Test Ok

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `compat` success on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `82fbf8d5eee7434b87b4582caed35f69ffdec534`

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 82fbf8d5eee7434b87b4582caed35f69ffdec534 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5702.631009538081 txn/s, latency: 5756.1657691546225 ms, (p50: 5100 ms, p90: 8900 ms, p99: 9700 ms), latency samples: 202040
2. Upgrading first Validator to new version: 82fbf8d5eee7434b87b4582caed35f69ffdec534
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1461.2279164515082 txn/s, latency: 19628.744431971263 ms, (p50: 19200 ms, p90: 30700 ms, p99: 31100 ms), latency samples: 89080
3. Upgrading rest of first batch to new version: 82fbf8d5eee7434b87b4582caed35f69ffdec534
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1353.5653957471184 txn/s, latency: 18864.161729518855 ms, (p50: 21800 ms, p90: 29300 ms, p99: 30000 ms), latency samples: 76900
4. upgrading second batch to new version: 82fbf8d5eee7434b87b4582caed35f69ffdec534
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2953.723204457026 txn/s, latency: 10213.481481189989 ms, (p50: 9900 ms, p90: 12300 ms, p99: 12900 ms), latency samples: 127060
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 82fbf8d5eee7434b87b4582caed35f69ffdec534 passed
Test Ok

msmouse commented 2 weeks ago

#13249 👈
#13283 : 1 other dependent PR (#13284 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @msmouse and the rest of your teammates on Graphite

github-actions[bot] commented 2 weeks ago

Forge is running suite `realistic_env_max_load` on `28076aaf382f3045543d7aa6ca13d930745682a2`

github-actions[bot] commented 2 weeks ago

Forge is running suite `framework_upgrade` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `28076aaf382f3045543d7aa6ca13d930745682a2`

github-actions[bot] commented 2 weeks ago

Forge is running suite `compat` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `28076aaf382f3045543d7aa6ca13d930745682a2`

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `compat` success on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `28076aaf382f3045543d7aa6ca13d930745682a2`

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5290.314710740663 txn/s, latency: 5447.658429610612 ms, (p50: 4800 ms, p90: 9000 ms, p99: 11900 ms), latency samples: 233700
2. Upgrading first Validator to new version: 28076aaf382f3045543d7aa6ca13d930745682a2
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1693.9030370348698 txn/s, latency: 16665.066922036953 ms, (p50: 19300 ms, p90: 22300 ms, p99: 22800 ms), latency samples: 88760
3. Upgrading rest of first batch to new version: 28076aaf382f3045543d7aa6ca13d930745682a2
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1679.4870989772169 txn/s, latency: 15783.421120969488 ms, (p50: 19100 ms, p90: 22000 ms, p99: 25000 ms), latency samples: 92420
4. upgrading second batch to new version: 28076aaf382f3045543d7aa6ca13d930745682a2
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3534.672441574259 txn/s, latency: 8878.859875346261 ms, (p50: 9600 ms, p90: 12700 ms, p99: 13000 ms), latency samples: 144400
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2 passed
Test Ok

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `realistic_env_max_load` success on `28076aaf382f3045543d7aa6ca13d930745682a2`

two traffics test: inner traffic : committed: 8080.8678873411145 txn/s, latency: 4849.750587975977 ms, (p50: 4500 ms, p90: 5700 ms, p99: 13200 ms), latency samples: 3493340
two traffics test : committed: 100.05156256990895 txn/s, latency: 1863.8155172413792 ms, (p50: 1800 ms, p90: 2100 ms, p99: 3600 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.206, avg: 0.202", "QsPosToProposal: max: 0.344, avg: 0.239", "ConsensusProposalToOrdered: max: 0.480, avg: 0.440", "ConsensusOrderedToCommit: max: 0.377, avg: 0.367", "ConsensusProposalToCommit: max: 0.847, avg: 0.807"]
Max round gap was 1 [limit 4] at version 1731548. Max no progress secs was 6.414748 [limit 15] at version 1731548.
Test Ok

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `framework_upgrade` success on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `28076aaf382f3045543d7aa6ca13d930745682a2`

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2 (PR)
Upgrade the nodes to version: 28076aaf382f3045543d7aa6ca13d930745682a2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1150.2883897885888 txn/s, submitted: 1153.8013911698863 txn/s, failed submission: 3.5130013812974656 txn/s, expired: 3.5130013812974656 txn/s, latency: 2545.4613953044473 ms, (p50: 2100 ms, p90: 4500 ms, p99: 7500 ms), latency samples: 104780
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1268.593516786563 txn/s, submitted: 1270.2668076509883 txn/s, failed submission: 1.6732908644254645 txn/s, expired: 1.6732908644254645 txn/s, latency: 2533.740653853401 ms, (p50: 2400 ms, p90: 4000 ms, p99: 5700 ms), latency samples: 106140
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2 passed
Upgrade the remaining nodes to version: 28076aaf382f3045543d7aa6ca13d930745682a2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1170.8030185685209 txn/s, submitted: 1173.6769685763363 txn/s, failed submission: 2.873950007815478 txn/s, expired: 2.873950007815478 txn/s, latency: 2663.390237915408 ms, (p50: 2100 ms, p90: 4500 ms, p99: 6100 ms), latency samples: 105920
Test Ok

aptos-labs / aptos-core