[Compiler-v2] fix timeout in third_party prover test

rahxephon89 commented 2 weeks ago

Description

This PR resolves the timeout issue in the third_party prover test by exchanging between source_dep and dep when creating the move model.

Also close #13251, close #13252

Type of Change

[ ] New feature
[x] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[x] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

Removed pragma verify=false from the spec of round in third_party/move/move-stdlib/sources/fixed_point32.move and the prover test still passes.

Key Areas to Review

When calling the prover in third_party and aptos, we need to make sure the same arguments passed to the move model builder, especially for source_deps and deps.

Checklist

[x] I have read and followed the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I identified and added all stakeholders and component owners affected by this change as reviewers
[x] I tested both happy and unhappy path of the functionality
[x] I have made corresponding changes to the documentation

trunk-io[bot] commented 2 weeks ago

⏱️ 11h 27m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974385156) | 2h 21m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24968404707) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974385156) | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/9087051899/job/24974151725) | 1h 46m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9085197272/job/24968047224) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9085197272/job/24969434115) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9085197272/job/24973051732) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051899/job/24974151725) | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/9087051884/job/24974037005) | 1h 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197328/job/24967922755) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051884/job/24974037005) | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974047222) | 1h 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554101/job/24922588729) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197269/job/24967936779) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974047222) | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974046553) | 1h 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197269/job/24967936172) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974046553) | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/9087051882/job/24974037869) | 38m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554123/job/24922578259) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051882/job/24974037869) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9087051891/job/24974037381) | 36m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554099/job/24922578140) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197268/job/24967923153) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051891/job/24974037381) | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974384630) | 30m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24968404463) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974384630) | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974384896) | 26m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24968404261) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974384896) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974052918) | 26m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24967938196) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974052918) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974046304) | 17m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554101/job/24922588292) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197269/job/24967935609) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974046304) | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974384499) | 15m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24968403427) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974384499) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/9087051880/job/24974052023) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554096/job/24922592800) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197298/job/24967941525) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051880/job/24974052023) | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974047437) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197269/job/24967937483) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974047437) | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/9087051876/job/24974037676) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197274/job/24967923581) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051876/job/24974037676) | | [test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974044543) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24967929945) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974044543) | | [execution-performance / test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9087051899/job/24974037586) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197272/job/24967923378) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051899/job/24974037586) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974046781) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554101/job/24922588509) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197269/job/24967935867) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974046781) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/9087051878/job/24974036850) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554107/job/24922577827) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197300/job/24967922436) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051878/job/24974036850) | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974385027) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24968403700) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974385027) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/9087051877/job/24974036791) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554109/job/24922577498) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197287/job/24967922418) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051877/job/24974036791) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9087051880/job/24974042933) | 34s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554096/job/24922582382) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197298/job/24967928792) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051880/job/24974042933) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974037735) | 34s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554101/job/24922578333) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197269/job/24967923396) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051887/job/24974037735) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974044183) | 26s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24967929740) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974044183) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9087051881/job/24974037048) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554102/job/24922577751) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197280/job/24967922729) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051881/job/24974037048) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974044350) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24967929497) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974044350) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9087051886/job/24974037052) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554094/job/24922577540) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197278/job/24967922455) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051886/job/24974037052) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974038062) | 6s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197364/job/24967923853) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051909/job/24974038062) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9087051880/job/24974037978) | 6s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554096/job/24922578141) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197298/job/24967923645) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051880/job/24974037978) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9087051879/job/24974037383) | 6s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9070554090/job/24922578008) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9085197271/job/24967923158) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9087051879/job/24974037383) |

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
cli-e2e-tests / run-cli-tests	9m	7m
windows-build	26m	39m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.6%. Comparing base (7719765) to head (498ba8f). Report is 3 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #13270 +/- ## ========================================= - Coverage 57.6% 57.6% -0.1% ========================================= Files 834 834 Lines 198396 198396 ========================================= - Hits 114325 114318 -7 - Misses 84071 84078 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.