search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
5.86k stars 3.54k forks source link

enable randomness #13308

Closed zjma closed 2 weeks ago

zjma commented 2 weeks ago

Description

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

trunk-io[bot] commented 2 weeks ago
⏱️ 6h 21m total CI duration on this PR | Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078927715) | 55m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384348/job/25074644078) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9120696515/job/25078542459) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078927715)  | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/9120819972/job/25078916305) | 50m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696509/job/25078541500) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819972/job/25078916305)  | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078927918) | 44m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9120696515/job/25078542289) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078927918)  | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/9120819975/job/25078910165) | 43m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819975/job/25078910165)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9120819961/job/25078910449) | 30m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384327/job/25074632758) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696513/job/25078536848) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819961/job/25078910449)  | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25078935729) | 29m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696550/job/25078543579) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25078935729)  | | [rust-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078928586) | 26m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078928586)  | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078927537) | 17m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384348/job/25074643889) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696515/job/25078542096) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078927537)  | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420924) | 17m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9120696550/job/25078870402) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420924)  | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420652) | 16m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9120696550/job/25078870249) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420652)  | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/9120819991/job/25078921580) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384335/job/25074647553) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696519/job/25078544246) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819991/job/25078921580)  | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078928143) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696515/job/25078542548) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078928143)  | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/9120819966/job/25078910612) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696507/job/25078536607) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819966/job/25078910612)  | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420179) | 8m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9120696550/job/25078870000) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420179)  | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078927289) | 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384348/job/25074644236) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696515/job/25078542205) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078927289)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/9120819973/job/25078910049) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384338/job/25074632198) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696517/job/25078536210) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819973/job/25078910049)  | | [indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420776) | 3m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9120696550/job/25078870561) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420776)  | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420338) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696550/job/25078870146) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25079420338)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/9120819956/job/25078909889) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384331/job/25074632400) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696505/job/25078536221) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819956/job/25078909889)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078918440) | 30s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384348/job/25074632937) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696515/job/25078536740) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819953/job/25078918440)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9120819991/job/25078914063) | 28s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384335/job/25074637842) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696519/job/25078539757) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819991/job/25078914063)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25078931464) | 21s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696550/job/25078540744) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25078931464)  | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9120819972/job/25078910489) | 16s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696509/job/25078536668) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819972/job/25078910489)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9120819986/job/25078910484) | 11s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384328/job/25074633147) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696520/job/25078536829) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819986/job/25078910484)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9120819994/job/25078910059) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384330/job/25074632150) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696521/job/25078536350) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819994/job/25078910059)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25078925785) | 7s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696550/job/25078537003) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25078925785)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9120819991/job/25078910727) | 6s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384335/job/25074632970) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696519/job/25078536568) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819991/job/25078910727)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9120819989/job/25078909998) | 6s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9119384336/job/25074632191) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696524/job/25078536467) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120819989/job/25078909998)  | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25078931232) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120696550/job/25078540833) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9120820029/job/25078931232)  |

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-images / rust-all 17m 13m +30%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

github-actions[bot] commented 2 weeks ago

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b1ecac6a8eff9ded75f213874015d3f3268401d

github-actions[bot] commented 2 weeks ago

Forge is running suite realistic_env_max_load on 0b1ecac6a8eff9ded75f213874015d3f3268401d

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b1ecac6a8eff9ded75f213874015d3f3268401d

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b1ecac6a8eff9ded75f213874015d3f3268401d (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6485 txn/s, latency: 5109 ms, (p50: 4800 ms, p90: 8900 ms, p99: 12900 ms), latency samples: 226980
2. Upgrading first Validator to new version: 0b1ecac6a8eff9ded75f213874015d3f3268401d
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1761 txn/s, latency: 16557 ms, (p50: 18300 ms, p90: 24300 ms, p99: 24600 ms), latency samples: 89820
3. Upgrading rest of first batch to new version: 0b1ecac6a8eff9ded75f213874015d3f3268401d
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1769 txn/s, latency: 15672 ms, (p50: 19500 ms, p90: 22000 ms, p99: 22600 ms), latency samples: 92020
4. upgrading second batch to new version: 0b1ecac6a8eff9ded75f213874015d3f3268401d
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3623 txn/s, latency: 8852 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12900 ms), latency samples: 144920
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b1ecac6a8eff9ded75f213874015d3f3268401d passed
Test Ok
github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite realistic_env_max_load success on 0b1ecac6a8eff9ded75f213874015d3f3268401d

two traffics test: inner traffic : committed: 8232 txn/s, latency: 4761 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10400 ms), latency samples: 3556300
two traffics test : committed: 100 txn/s, latency: 1845 ms, (p50: 1800 ms, p90: 2100 ms, p99: 5400 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.211, avg: 0.202", "QsPosToProposal: max: 0.231, avg: 0.212", "ConsensusProposalToOrdered: max: 0.455, avg: 0.392", "ConsensusOrderedToCommit: max: 0.375, avg: 0.361", "ConsensusProposalToCommit: max: 0.764, avg: 0.753"]
Max round gap was 1 [limit 4] at version 1784206. Max no progress secs was 4.703932 [limit 15] at version 1784206.
Test Ok