search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
5.86k stars 3.54k forks source link

[compiler v2] Emulating some unexpected v1 borrow behavior #13314

Closed wrwg closed 1 week ago

wrwg commented 2 weeks ago

Description

Fixes #12781

This also refactors and simplifies the releasing of references before write operations. I initially thought this was the problem but it wasn't, anyway the refactoring simplifies the code a bit.

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

New baseline test

trunk-io[bot] commented 2 weeks ago
⏱️ 10h 52m total CI duration on this PR | Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284644030) | 1h 32m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9122913786/job/25084495336) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246696/job/25206721174) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9185612652/job/25259886210) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619231/job/25259909242) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284644030)  | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/9193478713/job/25284623678) | 1h 18m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619239/job/25259897032) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478713/job/25284623678)  | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284643248) | 1h 5m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9185619231/job/25259909087) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284643248)  | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/9193478693/job/25284622033) | 59m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9122913788/job/25084487715) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246695/job/25206714116) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9185612664/job/25259879913) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185616997/job/25259893668) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478693/job/25284622033)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9193478707/job/25284622305) | 52m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246708/job/25206713960) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9185612647/job/25259879670) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9185616982/job/25259894864) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619242/job/25259899635) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478707/job/25284622305) (+1 more) | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/9193478763/job/25284805493) | 47m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619265/job/25259983498) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478763/job/25284805493)  | | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285323978) | 32m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25260332311) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285323978)  | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284642825) | 32m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9122913786/job/25084495230) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246696/job/25206721016) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9185612652/job/25259886092) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619231/job/25259908715) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284642825)  | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284641977) | 30m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25259907568) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284641977)  | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285322410) | 30m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25260331369) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25261143782) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285322410)  | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285322796) | 28m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25260332134) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285322796)  | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285323614) | 27m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25260331943) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285323614)  | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/9193478704/job/25284647727) | 22m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9122913730/job/25084495591) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246694/job/25206726312) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185612487/job/25259890024) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619434/job/25259914332) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478704/job/25284647727)  | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284644677) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619231/job/25259909404) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284644677)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/9193478688/job/25284621503) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246687/job/25206713562) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185616992/job/25259891669) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185612657/job/25259879057) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619235/job/25259896990) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478688/job/25284621503) (+2 more) | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/9193478685/job/25284621998) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619236/job/25259897924) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478685/job/25284621998)  | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284644364) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9122913786/job/25084495110) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246696/job/25206721320) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9185612652/job/25259885944) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619231/job/25259908522) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284644364)  | | [test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284634073) | 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25259903180) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284634073)  | | [execution-performance / test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9193478763/job/25284622071) | 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619265/job/25259897960) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478763/job/25284622071)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/9193478684/job/25284621639) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246690/job/25206713695) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185612669/job/25259879191) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185616984/job/25259891538) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619247/job/25259897288) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478684/job/25284621639) (+2 more) | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285321998) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25260331550) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25285321998)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284624053) | 58s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246696/job/25206714070) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185612652/job/25259880263) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9185617001/job/25259895789) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619231/job/25259899906) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478675/job/25284624053) (+1 more) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9193478704/job/25284632668) | 51s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246694/job/25206719863) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185612487/job/25259882823) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/9185616675/job/25259897564) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619434/job/25259904781) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478704/job/25284632668) (+1 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9193478697/job/25284623358) | 27s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246685/job/25206713745) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185612478/job/25259878326) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185616663/job/25259891018) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619419/job/25259897666) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478697/job/25284623358) (+2 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9193478681/job/25284623267) | 26s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246683/job/25206713569) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185612480/job/25259878365) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185616664/job/25259891044) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619424/job/25259897725) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478681/job/25284623267) (+2 more) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284633810) | 23s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25259903306) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284633810)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9193478704/job/25284622667) | 18s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246694/job/25206714288) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185612487/job/25259879032) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185616675/job/25259891172) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619434/job/25259900065) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478704/job/25284622667) (+1 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9193478689/job/25284622798) | 18s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9168246692/job/25206714109) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185612479/job/25259878731) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185616673/job/25259891183) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619422/job/25259899331) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478689/job/25284622798) (+1 more) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284623102) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25259898578) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284623102)  | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284633440) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9185619515/job/25259903500) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/9193478741/job/25284633440)  |

🚨 5 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 16m 9m +82%
cli-e2e-tests / run-cli-tests 12m 7m +78%
rust-build-cached-packages 8m 5m +57%
rust-lints 10m 7m +51%
rust-move-unit-coverage 13m 18m -27%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 32.9%. Comparing base (4da21b9) to head (083bd58). Report is 1 commits behind head on main.

Files Patch % Lines
...iler-v2/src/pipeline/reference_safety_processor.rs 0.0% 42 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13314 +/- ## ========================================= - Coverage 33.0% 32.9% -0.1% ========================================= Files 1768 1768 Lines 339266 339263 -3 ========================================= - Hits 111995 111840 -155 - Misses 227271 227423 +152 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

Forge is running suite realistic_env_max_load on cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f

github-actions[bot] commented 1 week ago

Forge is running suite framework_upgrade on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f

github-actions[bot] commented 1 week ago

Forge is running suite compat on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f

github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 7130.078730654867 txn/s, latency: 4621.062205387206 ms, (p50: 4800 ms, p90: 5700 ms, p99: 6900 ms), latency samples: 249480
2. Upgrading first Validator to new version: cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1850.3781018014827 txn/s, latency: 15476.209041747783 ms, (p50: 19400 ms, p90: 21800 ms, p99: 22300 ms), latency samples: 92460
3. Upgrading rest of first batch to new version: cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1847.3985477714357 txn/s, latency: 15498.041529462738 ms, (p50: 19000 ms, p90: 21800 ms, p99: 22300 ms), latency samples: 92320
4. upgrading second batch to new version: cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3557.118152946707 txn/s, latency: 8794.567964196503 ms, (p50: 9600 ms, p90: 12700 ms, p99: 13000 ms), latency samples: 144120
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f passed
Test Ok
github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite realistic_env_max_load success on cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f

two traffics test: inner traffic : committed: 8123.131519416272 txn/s, latency: 4827.440445278541 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10900 ms), latency samples: 3506120
two traffics test : committed: 99.9749945506353 txn/s, latency: 1917.2637362637363 ms, (p50: 1800 ms, p90: 2000 ms, p99: 8200 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.202", "QsPosToProposal: max: 0.231, avg: 0.217", "ConsensusProposalToOrdered: max: 0.484, avg: 0.440", "ConsensusOrderedToCommit: max: 0.376, avg: 0.348", "ConsensusProposalToCommit: max: 0.817, avg: 0.788"]
Max round gap was 1 [limit 4] at version 1744729. Max no progress secs was 6.204102 [limit 15] at version 1744729.
Test Ok
github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite framework_upgrade success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f (PR)
Upgrade the nodes to version: cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1049.2205556861882 txn/s, submitted: 1051.8639834981204 txn/s, failed submission: 2.6434278119324497 txn/s, expired: 2.6434278119324497 txn/s, latency: 2905.869284064665 ms, (p50: 2100 ms, p90: 5100 ms, p99: 7800 ms), latency samples: 95260
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1112.5029509283513 txn/s, submitted: 1114.4793675407388 txn/s, failed submission: 1.9764166123875173 txn/s, expired: 1.9764166123875173 txn/s, latency: 2658.9725128306354 ms, (p50: 2100 ms, p90: 4500 ms, p99: 7200 ms), latency samples: 101320
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f passed
Upgrade the remaining nodes to version: cc88ce9cc83c5d06800de1e777aa8c7b995ceb5f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1167.0727631053148 txn/s, submitted: 1169.179392641606 txn/s, failed submission: 2.106629536291182 txn/s, expired: 2.106629536291182 txn/s, latency: 2731.970086241476 ms, (p50: 2100 ms, p90: 5100 ms, p99: 7500 ms), latency samples: 99720
Test Ok
github-actions[bot] commented 1 week ago

Forge is running suite framework_upgrade on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 083bd58443479c89796c74555f3681c24c3723d3

github-actions[bot] commented 1 week ago

Forge is running suite compat on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 083bd58443479c89796c74555f3681c24c3723d3

github-actions[bot] commented 1 week ago

Forge is running suite realistic_env_max_load on 083bd58443479c89796c74555f3681c24c3723d3

github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 083bd58443479c89796c74555f3681c24c3723d3

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 083bd58443479c89796c74555f3681c24c3723d3 (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 6801.522066260085 txn/s, latency: 4836.229302859016 ms, (p50: 4800 ms, p90: 8000 ms, p99: 8500 ms), latency samples: 244140
2. Upgrading first Validator to new version: 083bd58443479c89796c74555f3681c24c3723d3
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1487.831750092359 txn/s, latency: 20783.535725885027 ms, (p50: 27500 ms, p90: 29600 ms, p99: 30200 ms), latency samples: 61580
3. Upgrading rest of first batch to new version: 083bd58443479c89796c74555f3681c24c3723d3
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2923.3145600531766 txn/s, latency: 10609.058182853425 ms, (p50: 9800 ms, p90: 14200 ms, p99: 14500 ms), latency samples: 122940
4. upgrading second batch to new version: 083bd58443479c89796c74555f3681c24c3723d3
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6465.42605961615 txn/s, latency: 5080.684569450455 ms, (p50: 4800 ms, p90: 8200 ms, p99: 9300 ms), latency samples: 231100
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 083bd58443479c89796c74555f3681c24c3723d3 passed
Test Ok
github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite realistic_env_max_load success on 083bd58443479c89796c74555f3681c24c3723d3

two traffics test: inner traffic : committed: 7864.801220546377 txn/s, latency: 4968.654083386116 ms, (p50: 4800 ms, p90: 6900 ms, p99: 11100 ms), latency samples: 3410160
two traffics test : committed: 99.98810701091804 txn/s, latency: 1876.5604395604396 ms, (p50: 1800 ms, p90: 2100 ms, p99: 4800 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.216, avg: 0.204", "QsPosToProposal: max: 0.272, avg: 0.258", "ConsensusProposalToOrdered: max: 0.449, avg: 0.420", "ConsensusOrderedToCommit: max: 0.386, avg: 0.373", "ConsensusProposalToCommit: max: 0.802, avg: 0.793"]
Max round gap was 1 [limit 4] at version 1636635. Max no progress secs was 4.66593 [limit 15] at version 1636635.
Test Ok
github-actions[bot] commented 1 week ago

:white_check_mark: Forge suite framework_upgrade success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 083bd58443479c89796c74555f3681c24c3723d3

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 083bd58443479c89796c74555f3681c24c3723d3 (PR)
Upgrade the nodes to version: 083bd58443479c89796c74555f3681c24c3723d3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1063.5901398338751 txn/s, submitted: 1066.0034012897688 txn/s, failed submission: 2.413261455893694 txn/s, expired: 2.413261455893694 txn/s, latency: 2969.9663056930694 ms, (p50: 2100 ms, p90: 5100 ms, p99: 11600 ms), latency samples: 96960
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1100.5844179163958 txn/s, submitted: 1102.9512661269687 txn/s, failed submission: 2.3668482105728943 txn/s, expired: 2.3668482105728943 txn/s, latency: 2898.681677419355 ms, (p50: 2100 ms, p90: 5200 ms, p99: 9000 ms), latency samples: 93000
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 083bd58443479c89796c74555f3681c24c3723d3 passed
Upgrade the remaining nodes to version: 083bd58443479c89796c74555f3681c24c3723d3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1152.3768098203454 txn/s, submitted: 1153.313130608337 txn/s, failed submission: 0.936320787991343 txn/s, expired: 0.936320787991343 txn/s, latency: 2828.4813426772293 ms, (p50: 2100 ms, p90: 5100 ms, p99: 9000 ms), latency samples: 98460
Test Ok