search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
6.12k stars 3.62k forks source link

[Feature Request] Improve Simulation for Sponsored Transactions #13686

Open gregnazario opened 3 months ago

gregnazario commented 3 months ago

🚀 Feature Request

Sponsored transactions, and any transaction where a publickey is not known, should be able to simulate. In the event of a 0x0 fee payer, there should be no gas simulation issues.

Motivation

Sponsored transactions can't be easily simulated without knowing the public key and address of the sponsor for a transaction. This is messy, since if you may not know the fee payer's address and public key if it's set to 0x0 to allow for any fee payer.

Pitch

Describe the solution you'd like Simulation ignoring public keys, and if a fee payer is set, ignoring gas fees.

Describe alternatives you've considered ^

Are you willing to open a pull request? (See CONTRIBUTING) n/a

Additional context

alex4506 commented 3 months ago

Hi, guys, how is this matter going? Currently, our multisig v2 + fee payer transactions cannot be simulated at all. A lot of gas was wasted due to the submission of incorrect payloads.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

junkil-park commented 1 month ago

Hi, guys, how is this matter going? Currently, our multisig v2 + fee payer transactions cannot be simulated at all. A lot of gas was wasted due to the submission of incorrect payloads.

@alex4506 , the AIP-92 should resolve this issue, and it's going to be released with v1.19.