aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.

https://aptosfoundation.org

Other

6.18k stars 3.65k forks source link

[Bug][move-compiler-v2] Compiler V2 misses key ability errors, with an edited test yields a "bug" #14629

Open brmataptos opened 2 months ago

brmataptos commented 2 months ago

🐛 Bug

Compiler V1 catches some "missing ability key" errors which are missed by Compiler V2:

third_party/move/move-compiler/tests/move_check/typing/pack_constraint_not_satisfied.exp
third_party/move/move-compiler-v2/tests/ability-check/v1-typing/pack_constraint_not_satisfied.exp

Reducing the test to try to eliminate error shadowing:

third_party/move/move-compiler/tests/move_check/typing/pack_constraint_not_satisfied2.exp
third_party/move/move-compiler-v2/tests/ability-check/v1-typing/pack_constraint_not_satisfied2.exp yields a compiler "bug" from V2 instead of the expected "key" errors:
```
Diagnostics:
bug: unexpected type: _
┌─ tests/ability-check/v1-typing/pack_constraint_not_satisfied2.move:6:9
│
6 │     fun t0() {
│         ^^
```

wrwg commented 1 week ago

Might be fixed by now as something in this area was recently fixed.