search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
6.19k stars 3.66k forks source link

[compiler-v2] Test case reduced from move-stdlib showing opportunity for optimization #15338

Closed vineethk closed 17 hours ago

vineethk commented 5 days ago

Description

Adds a test case to support the description in the issue: https://github.com/aptos-labs/aptos-core/issues/15339.

This test case was reduced from a function (vector::reverse_append) in move stdlib.

How Has This Been Tested?

Test added.

trunk-io[bot] commented 5 days ago
⏱️ 2h 49m total CI duration on this PR | Slowest 15 Jobs | Cumulative Duration | Recent Runs | |---|---|---| | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/12018652976/job/33503805099) | 46m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016121973/job/33495889077) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652976/job/33503805099)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11942342158/job/33289173108) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11942342158/job/33289173108)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/12016121919/job/33495648832) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016121919/job/33495648832)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11973670855/job/33383072665) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11973670855/job/33383072665)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/12018652956/job/33503616960) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652956/job/33503616960)  | | [rust-cargo-deny](https://github.com/aptos-labs/aptos-core/actions/runs/12018652954/job/33503625191) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11942342169/job/33289187483) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11973670839/job/33383088863) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016122022/job/33495668176) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/12018641648/job/33503580543) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652954/job/33503625191) (+1 more) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/12018652960/job/33503604924) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11973670854/job/33383071669) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016120424/job/33495641782) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016121924/job/33495645629) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018641635/job/33503565887) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652960/job/33503604924) (+2 more) | | [execution-performance / test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/12018652976/job/33503605656) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016121973/job/33495647047) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652976/job/33503605656)  | | [test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/12018652977/job/33503611993) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016122088/job/33495658004) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652977/job/33503611993)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11942244901/job/33288833470) | 8m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/11942244901/job/33288833470)  | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/12018652971/job/33503605726) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016121932/job/33495646969) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652971/job/33503605726)  | | [rust-doc-tests](https://github.com/aptos-labs/aptos-core/actions/runs/12016122022/job/33495654761) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016122022/job/33495654761)  | | [rust-doc-tests](https://github.com/aptos-labs/aptos-core/actions/runs/12018652954/job/33503616002) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652954/job/33503616002)  | | [fetch-last-released-docker-image-tag](https://github.com/aptos-labs/aptos-core/actions/runs/12018652977/job/33503612512) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016122088/job/33495657707) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652977/job/33503612512)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/12018652970/job/33503604796) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11973670845/job/33383071585) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016120438/job/33495641780) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12016121929/job/33495645876) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018641641/job/33503565927) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12018652970/job/33503604796) (+2 more) |

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

vineethk commented 5 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 20 hours ago

Forge is running suite realistic_env_max_load on bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40

github-actions[bot] commented 20 hours ago

Forge is running suite compat on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40

github-actions[bot] commented 20 hours ago

Forge is running suite framework_upgrade on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40

github-actions[bot] commented 20 hours ago

:white_check_mark: Forge suite realistic_env_max_load success on bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40

two traffics test: inner traffic : committed: 13900.97 txn/s, latency: 2857.07 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5285560
two traffics test : committed: 99.96 txn/s, latency: 1824.10 ms, (p50: 1600 ms, p70: 1900, p90: 2200 ms, p99: 8500 ms), latency samples: 1860
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.396, avg: 1.444", "ConsensusProposalToOrdered: max: 0.336, avg: 0.297", "ConsensusOrderedToCommit: max: 0.381, avg: 0.368", "ConsensusProposalToCommit: max: 0.680, avg: 0.665"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.20s no progress at version 2868246 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.36s no progress at version 2868244 (avg 15.36s) [limit 16].
Test Ok
github-actions[bot] commented 20 hours ago

:white_check_mark: Forge suite framework_upgrade success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40 (PR)
Upgrade the nodes to version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1364.34 txn/s, submitted: 1367.06 txn/s, failed submission: 2.71 txn/s, expired: 2.71 txn/s, latency: 2251.34 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5100 ms), latency samples: 120640
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1333.14 txn/s, submitted: 1335.42 txn/s, failed submission: 2.28 txn/s, expired: 2.28 txn/s, latency: 2300.72 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5200 ms), latency samples: 116720
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40 passed
Upgrade the remaining nodes to version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1369.24 txn/s, submitted: 1371.91 txn/s, failed submission: 2.67 txn/s, expired: 2.67 txn/s, latency: 2267.58 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5200 ms), latency samples: 122960
Test Ok
github-actions[bot] commented 20 hours ago

:white_check_mark: Forge suite compat success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40 (PR)
1. Check liveness of validators at old version: 94976266c0e4edd1a31a3783be4c4184f8892ff5
compatibility::simple-validator-upgrade::liveness-check : committed: 10359.66 txn/s, latency: 2466.64 ms, (p50: 1800 ms, p70: 1900, p90: 2700 ms, p99: 33600 ms), latency samples: 483500
2. Upgrading first Validator to new version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4350.53 txn/s, latency: 6770.66 ms, (p50: 7300 ms, p70: 8100, p90: 8300 ms, p99: 8500 ms), latency samples: 93680
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4470.92 txn/s, latency: 7328.29 ms, (p50: 7700 ms, p70: 8200, p90: 8700 ms, p99: 9700 ms), latency samples: 166200
3. Upgrading rest of first batch to new version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 1301.36 txn/s, latency: 17640.31 ms, (p50: 19200 ms, p70: 25400, p90: 28200 ms, p99: 29300 ms), latency samples: 55440
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5761.29 txn/s, latency: 5633.09 ms, (p50: 4600 ms, p70: 5500, p90: 11000 ms, p99: 11600 ms), latency samples: 194280
4. upgrading second batch to new version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9855.83 txn/s, latency: 2742.31 ms, (p50: 2200 ms, p70: 3400, p90: 4600 ms, p99: 5500 ms), latency samples: 175960
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9061.07 txn/s, latency: 3406.57 ms, (p50: 2500 ms, p70: 4500, p90: 5600 ms, p99: 7400 ms), latency samples: 300320
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40 passed
Test Ok
github-actions[bot] commented 17 hours ago

Forge is running suite compat on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909

github-actions[bot] commented 17 hours ago

Forge is running suite realistic_env_max_load on 2b382427e897f529ede1956160e73c5897d98909

github-actions[bot] commented 17 hours ago

Forge is running suite framework_upgrade on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909

github-actions[bot] commented 17 hours ago

:white_check_mark: Forge suite realistic_env_max_load success on 2b382427e897f529ede1956160e73c5897d98909

two traffics test: inner traffic : committed: 14021.02 txn/s, latency: 2836.00 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 9700 ms), latency samples: 5331120
two traffics test : committed: 99.94 txn/s, latency: 2047.66 ms, (p50: 2000 ms, p70: 2200, p90: 2400 ms, p99: 6800 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.922, avg: 1.102", "ConsensusProposalToOrdered: max: 0.323, avg: 0.296", "ConsensusOrderedToCommit: max: 0.376, avg: 0.365", "ConsensusProposalToCommit: max: 0.670, avg: 0.660"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.08s no progress at version 2167381 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.52s no progress at version 2167379 (avg 15.52s) [limit 16].
Test Ok
github-actions[bot] commented 17 hours ago

:white_check_mark: Forge suite compat success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909 (PR)
1. Check liveness of validators at old version: 94976266c0e4edd1a31a3783be4c4184f8892ff5
compatibility::simple-validator-upgrade::liveness-check : committed: 13745.84 txn/s, latency: 2121.53 ms, (p50: 1800 ms, p70: 1900, p90: 2200 ms, p99: 16600 ms), latency samples: 548140
2. Upgrading first Validator to new version: 2b382427e897f529ede1956160e73c5897d98909
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7845.80 txn/s, latency: 3571.68 ms, (p50: 4000 ms, p70: 4300, p90: 4700 ms, p99: 5000 ms), latency samples: 137780
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7888.42 txn/s, latency: 4086.78 ms, (p50: 4200 ms, p70: 4400, p90: 5900 ms, p99: 6100 ms), latency samples: 258560
3. Upgrading rest of first batch to new version: 2b382427e897f529ede1956160e73c5897d98909
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7022.80 txn/s, latency: 4066.54 ms, (p50: 4600 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 130660
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6525.79 txn/s, latency: 4931.75 ms, (p50: 5000 ms, p70: 5200, p90: 7000 ms, p99: 7400 ms), latency samples: 217640
4. upgrading second batch to new version: 2b382427e897f529ede1956160e73c5897d98909
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12244.02 txn/s, latency: 2277.89 ms, (p50: 2600 ms, p70: 2600, p90: 2700 ms, p99: 2700 ms), latency samples: 212220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10446.21 txn/s, latency: 2970.66 ms, (p50: 2700 ms, p70: 2800, p90: 5700 ms, p99: 7100 ms), latency samples: 337600
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909 passed
Test Ok
github-actions[bot] commented 17 hours ago

:white_check_mark: Forge suite framework_upgrade success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909 (PR)
Upgrade the nodes to version: 2b382427e897f529ede1956160e73c5897d98909
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1407.33 txn/s, submitted: 1409.54 txn/s, failed submission: 2.21 txn/s, expired: 2.21 txn/s, latency: 2192.12 ms, (p50: 2100 ms, p70: 2300, p90: 3300 ms, p99: 5100 ms), latency samples: 127200
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1365.44 txn/s, submitted: 1368.09 txn/s, failed submission: 2.65 txn/s, expired: 2.65 txn/s, latency: 2161.80 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4700 ms), latency samples: 123660
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909 passed
Upgrade the remaining nodes to version: 2b382427e897f529ede1956160e73c5897d98909
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1364.07 txn/s, submitted: 1366.33 txn/s, failed submission: 2.25 txn/s, expired: 2.25 txn/s, latency: 2285.26 ms, (p50: 2100 ms, p70: 2400, p90: 3700 ms, p99: 4500 ms), latency samples: 121220
Test Ok