search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
6.19k stars 3.66k forks source link

[cp 1.23] Move payload_manager.notify_commit() to after commit #15359

Closed msmouse closed 3 days ago

msmouse commented 4 days ago

this is to cherry-pick https://github.com/aptos-labs/aptos-core/pull/15361 to v1.23

trunk-io[bot] commented 4 days ago
⏱️ 4h 5m total CI duration on this PR | Slowest 15 Jobs | Cumulative Duration | Recent Runs | |---|---|---| | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/11977883387/job/33396997415) | 54m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376457/job/33353857649) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883387/job/33396997415)  | | [rust-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11963376444/job/33358772843) | 43m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/11963376444/job/33353708596) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376444/job/33358772843)  | | [rust-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11977883375/job/33398314993) | 42m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/11977883375/job/33396743518) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883375/job/33398314993)  | | [rust-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11963151996/job/33353050017) | 19m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/11963151996/job/33353050017)  | | [execution-performance / test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/11977883387/job/33396741944) | 11m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376457/job/33353698590) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883387/job/33396741944)  | | [test-target-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/11977883468/job/33396749118) | 10m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376516/job/33353704545) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883468/job/33396749118)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11977883409/job/33396741983) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883409/job/33396741983)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11963151989/job/33353048997) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963151989/job/33353048997)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11963376458/job/33353698587) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376458/job/33353698587)  | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/11977883352/job/33396742510) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376468/job/33353698711) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883352/job/33396742510)  | | [rust-cargo-deny](https://github.com/aptos-labs/aptos-core/actions/runs/11977883375/job/33396790095) | 7m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/11963132790/job/33352992645) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963151996/job/33353059870) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376444/job/33353715626) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883375/job/33396790095)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/11977883351/job/33396741197) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963152000/job/33353038420) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963132784/job/33352980776) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376464/job/33353697803) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883351/job/33396741197)  | | [rust-doc-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11963376444/job/33353708395) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376444/job/33353708395)  | | [rust-doc-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11977883375/job/33396742528) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883375/job/33396742528)  | | [fetch-last-released-docker-image-tag](https://github.com/aptos-labs/aptos-core/actions/runs/11977883468/job/33396750134) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11963376516/job/33353705103) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11977883468/job/33396750134)  |

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 27m 16m +65%
execution-performance / test-target-determinator 6m 4m +35%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

github-actions[bot] commented 4 days ago

Forge is running suite realistic_env_max_load on 419d75130bd385cda0e950bcd2547f947a489ef4

github-actions[bot] commented 4 days ago

Forge is running suite compat on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4

github-actions[bot] commented 4 days ago

:white_check_mark: Forge suite realistic_env_max_load success on 419d75130bd385cda0e950bcd2547f947a489ef4

two traffics test: inner traffic : committed: 14388.27 txn/s, latency: 2762.91 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5470700
two traffics test : committed: 99.91 txn/s, latency: 1405.74 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 1600 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.021, avg: 1.585", "ConsensusProposalToOrdered: max: 0.320, avg: 0.295", "ConsensusOrderedToCommit: max: 0.372, avg: 0.358", "ConsensusProposalToCommit: max: 0.667, avg: 0.653"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.80s no progress at version 2857682 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.60s no progress at version 2857680 (avg 8.60s) [limit 15].
Test Ok
github-actions[bot] commented 4 days ago

:white_check_mark: Forge suite compat success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 (PR)
1. Check liveness of validators at old version: afa8d75c467820b7d96bbe13ab0d011c12f8b3a3
compatibility::simple-validator-upgrade::liveness-check : committed: 14292.90 txn/s, latency: 2166.92 ms, (p50: 1800 ms, p70: 1900, p90: 2400 ms, p99: 15900 ms), latency samples: 560520
2. Upgrading first Validator to new version: 419d75130bd385cda0e950bcd2547f947a489ef4
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7862.35 txn/s, latency: 3515.42 ms, (p50: 3600 ms, p70: 4200, p90: 4800 ms, p99: 5000 ms), latency samples: 143120
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7832.53 txn/s, latency: 4110.00 ms, (p50: 4200 ms, p70: 4400, p90: 5900 ms, p99: 6100 ms), latency samples: 254620
3. Upgrading rest of first batch to new version: 419d75130bd385cda0e950bcd2547f947a489ef4
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7956.70 txn/s, latency: 3571.16 ms, (p50: 4000 ms, p70: 4200, p90: 4300 ms, p99: 4500 ms), latency samples: 144100
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7302.74 txn/s, latency: 4342.67 ms, (p50: 4300 ms, p70: 4300, p90: 6700 ms, p99: 6900 ms), latency samples: 240540
4. upgrading second batch to new version: 419d75130bd385cda0e950bcd2547f947a489ef4
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 4631.12 txn/s, latency: 5944.05 ms, (p50: 5700 ms, p70: 9600, p90: 10800 ms, p99: 11300 ms), latency samples: 81300
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10444.17 txn/s, latency: 2958.33 ms, (p50: 2400 ms, p70: 3700, p90: 5100 ms, p99: 6200 ms), latency samples: 356880
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 passed
Test Ok
trunk-io[bot] commented 4 days ago

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

github-actions[bot] commented 3 days ago

Forge is running suite framework_upgrade on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4

github-actions[bot] commented 3 days ago

Forge is running suite compat on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4

github-actions[bot] commented 3 days ago

Forge is running suite realistic_env_max_load on 419d75130bd385cda0e950bcd2547f947a489ef4

github-actions[bot] commented 3 days ago

:white_check_mark: Forge suite realistic_env_max_load success on 419d75130bd385cda0e950bcd2547f947a489ef4

two traffics test: inner traffic : committed: 14273.61 txn/s, latency: 2783.35 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5427160
two traffics test : committed: 99.95 txn/s, latency: 1474.23 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 6100 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.019, avg: 1.593", "ConsensusProposalToOrdered: max: 0.316, avg: 0.295", "ConsensusOrderedToCommit: max: 0.391, avg: 0.370", "ConsensusProposalToCommit: max: 0.690, avg: 0.665"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.17s no progress at version 2076115 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.50s no progress at version 2076113 (avg 7.33s) [limit 15].
Test Ok
github-actions[bot] commented 3 days ago

:white_check_mark: Forge suite framework_upgrade success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 (PR)
Upgrade the nodes to version: 419d75130bd385cda0e950bcd2547f947a489ef4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1361.19 txn/s, submitted: 1361.97 txn/s, failed submission: 0.78 txn/s, expired: 0.78 txn/s, latency: 2715.55 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5200 ms), latency samples: 105320
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1305.19 txn/s, submitted: 1307.44 txn/s, failed submission: 2.25 txn/s, expired: 2.25 txn/s, latency: 2319.65 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5300 ms), latency samples: 115880
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 passed
Upgrade the remaining nodes to version: 419d75130bd385cda0e950bcd2547f947a489ef4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1298.46 txn/s, submitted: 1301.85 txn/s, failed submission: 3.38 txn/s, expired: 3.38 txn/s, latency: 2318.91 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5500 ms), latency samples: 115080
Test Ok
github-actions[bot] commented 3 days ago

:white_check_mark: Forge suite compat success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 (PR)
1. Check liveness of validators at old version: afa8d75c467820b7d96bbe13ab0d011c12f8b3a3
compatibility::simple-validator-upgrade::liveness-check : committed: 14384.39 txn/s, latency: 2370.74 ms, (p50: 1900 ms, p70: 2100, p90: 3300 ms, p99: 9600 ms), latency samples: 497340
2. Upgrading first Validator to new version: 419d75130bd385cda0e950bcd2547f947a489ef4
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7380.36 txn/s, latency: 3740.34 ms, (p50: 4100 ms, p70: 4400, p90: 4600 ms, p99: 4700 ms), latency samples: 135320
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7190.69 txn/s, latency: 4464.15 ms, (p50: 4700 ms, p70: 4900, p90: 6100 ms, p99: 6400 ms), latency samples: 243340
3. Upgrading rest of first batch to new version: 419d75130bd385cda0e950bcd2547f947a489ef4
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7888.14 txn/s, latency: 3637.33 ms, (p50: 4100 ms, p70: 4300, p90: 4400 ms, p99: 4400 ms), latency samples: 146360
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2925.82 txn/s, submitted: 2925.95 txn/s, expired: 0.13 txn/s, latency: 4133.22 ms, (p50: 4500 ms, p70: 4600, p90: 4800 ms, p99: 5100 ms), latency samples: 256589
4. upgrading second batch to new version: 419d75130bd385cda0e950bcd2547f947a489ef4
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12015.49 txn/s, latency: 2330.77 ms, (p50: 2500 ms, p70: 2600, p90: 2900 ms, p99: 3100 ms), latency samples: 205480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10184.30 txn/s, latency: 3042.76 ms, (p50: 2600 ms, p70: 3000, p90: 6100 ms, p99: 7800 ms), latency samples: 331080
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 passed
Test Ok