aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
6.19k stars 3.66k forks source link

[move-compiler-v2] clean up a few remaining issues in lambda parser/front-end code #15365

Open brmataptos opened 4 days ago

brmataptos commented 4 days ago

Description

Various fixes:

How Has This Been Tested?

Usual tests run, showing unchanged behavior on existing code. Tests under /lambda/ without .lambda. config show proper errors generated if to many functions are used. _ok tests now show code working up until "not implemented" errors.

Key Areas to Review

Most complex stuff is in previous PR, but:

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io[bot] commented 4 days ago
⏱️ 48m total CI duration on this PR | Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11980563118/job/33405054300) | 12m | [πŸŸ₯](https://github.com/aptos-labs/aptos-core/actions/runs/11980563118/job/33405054300)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11964848942/job/33357868318) | 12m | [πŸŸ₯](https://github.com/aptos-labs/aptos-core/actions/runs/11964848942/job/33357868318)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/12003517591/job/33457094205) | 12m | [πŸŸ₯](https://github.com/aptos-labs/aptos-core/actions/runs/12003517591/job/33457094205)  | | [rust-cargo-deny](https://github.com/aptos-labs/aptos-core/actions/runs/12003517592/job/33457101696) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11964848940/job/33357877996) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11980563113/job/33405063687) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12003517592/job/33457101696)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/12003517605/job/33457094005) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11964848932/job/33357867788) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11980563108/job/33405053844) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12003517605/job/33457094005)  | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/12003517592/job/33457101962) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11964848940/job/33357878350) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11980563113/job/33405063261) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12003517592/job/33457101962)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/12003517595/job/33457093887) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11964848936/job/33357867873) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11980563130/job/33405054034) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12003517595/job/33457093887)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/12003517592/job/33457094333) | 35s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11964848940/job/33357868211) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11980563113/job/33405054318) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12003517592/job/33457094333)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/12003517596/job/33457093916) | 16s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11964848913/job/33357867608) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11980563213/job/33405054567) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12003517596/job/33457093916)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/12003517627/job/33457094289) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11964848915/job/33357867661) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11980563196/job/33405054532) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/12003517627/job/33457094289)  | | [check-branch-prefix](https://github.com/aptos-labs/aptos-core/actions/runs/11964848559/job/33357866452) | 1s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11964848559/job/33357866452)  |

settings β‹… feedback β‹… docs β‹… learn more about trunk.io

brmataptos commented 4 days ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.