aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
6.18k stars 3.66k forks source link

[Draft] Fix round manager tests #15369

Open vusirikala opened 5 hours ago

vusirikala commented 5 hours ago

Description

The round manager tests are outdated. They work only when broadcast_vote and order_vote flags are disabled, which doesn't actually match with the mainnet settings. This PR aims to address the issue by fixing the round manager tests.

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io[bot] commented 5 hours ago
⏱️ 17m total CI duration on this PR | Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/11978398783/job/33398326613) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11978398783/job/33398326613)  | | [rust-cargo-deny](https://github.com/aptos-labs/aptos-core/actions/runs/11978398772/job/33398339277) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11978398772/job/33398339277)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/11978398775/job/33398325868) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11978398775/job/33398325868)  | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/11978398772/job/33398339824) | 29s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11978398772/job/33398339824)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/11978398765/job/33398325468) | 27s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11978398765/job/33398325468)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/11978398772/job/33398326857) | 11s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11978398772/job/33398326857)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/11978398338/job/33398324138) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11978398338/job/33398324138)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/11978398327/job/33398324107) | 2s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/11978398327/job/33398324107)  |

settings β‹… feedback β‹… docs β‹… learn more about trunk.io