cleanup docker compose and fullnode/validator templates to avoid operator confusion

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.

https://aptosfoundation.org

Other

6.18k stars 3.64k forks source link

cleanup docker compose and fullnode/validator templates to avoid operator confusion #2435

Closed geekflyer closed 1 year ago

geekflyer commented 2 years ago

As discussed in https://aptos-org.slack.com/archives/C034W35ARFX/p1659318103411649 the fullnode+validator docker configs and config files could use some love and cleanup.

Specifically:

consider removing docker/compose/public_full_node in favor of aptos-node
consider removing docker/compose/validator-testnet in favor of aptos node run-local-testnet --with-faucet
rename docker/compose/aptos-node/docker-compose.yaml to docker-compose-validator.yaml
consider increasing consistency with between validator/node config files. At the moment we have various config files spread throughout the repo and it's not clear what's intentional vs accidental differences between some of them.
- In general make the intention of each compose or node config file template clear.
- Update the docs accordingly

ilhanu commented 2 years ago

The current instructions for docker on devnet don't work for me on ubuntu 20.04 and 22.04 with latest docker installed using the convenience script.

Output is here

hairangsua commented 2 years ago

the same as me. i follow step by step in documents but stuck.

it alway show this error

_Node should start correctly: DB failed to bootstrap status INVALID_WRITESET of type Validation

geekflyer commented 2 years ago

@ilhanu @hairangsua thanks for reporting. I did a quick fix to update the instructions here https://github.com/aptos-labs/aptos-core/commit/58125560a47ab1bde9bca464956c8e8a74a7582f . The cause appears that we published yesterday already docker images for the next devnet release, without updating our DevNet validators to that version. With my fix the instructions will download a specific version of the docker image that corresponds to the DevNet release from last week which is currently active.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.