aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
6.14k stars 3.62k forks source link

[SDK][Rust] Break dependency on storage and other core crates #6762

Open procodeninja33 opened 1 year ago

procodeninja33 commented 1 year ago

aptos-sdk library should compile only required library. During the compile this aptos-sdk, it's uses another internal library and then rocksdb as well. It takes more time to compile My main concern here is rocksdb library. it slow down the whole compiling process even I don't want it.

ghost commented 1 year ago

I could agree, when I only to use aptos-rest-client crate, it will instead to compile a whole project.

procodeninja33 commented 1 year ago

@clay-aptos @gregnazario @saharct I just wanted to tag you guys and let you know that please have a look about this issue and assign appropriate developer

clay-aptos commented 1 year ago

@clay-aptos @gregnazario @saharct I just wanted to tag you guys and let you know that please have a look about this issue and assign appropriate developer

Thank you. I've added some of my peers to take a look.

banool commented 1 year ago

Unfortunately the way it works now the SDK includes the REST client, which relies on the API types, which themselves rely on the storage interface, which I believe then eventually depends on much of the codebase, including the rocksdb dependency. In a future API iteration it might be possible to break this dependency chain. Given all the other exciting work on our roadmap I don't think we can specifically prioritize this work right now though.

clay-aptos commented 1 year ago

Thanks, Daniel. @procodeninja33 , please let me know if it would help to have this answer documented.

procodeninja33 commented 1 year ago

@clay-aptos , I am partially satisfied with @banool the answer. Definitely this one is not an priority, but you should add this point in future enhancement (It will make the aptos* library very light weight).

banool commented 1 year ago

We'll add this item to our backlog :)

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

procodeninja33 commented 1 year ago

I don't know why this issue was closed without even being addressed. I understand that the priority is low, but it would be great if it's addressed. Thank you.

nizam-supraoracles commented 8 months ago

@banool @clay-aptos @gregnazario, Due to inactivity on this issue, it has been closed. However, the problem remains unaddressed. It appears that Sui has addressed the issue I raised link to the issue. Could you please reopen this issue and provide a resolution?

banool commented 8 months ago

Hey,

I agree it'd be great if we could fix this issue, there have been multiple occasions where I want to use SDK types but I avoid it because it's too heavy.

We'll discuss the priority for this.

nizam-supraoracles commented 3 months ago

I am reaching out to inquire about the status of this issue before the ticket is automatically closed.

banool commented 3 months ago

We have begun work on a Rust SDK that is separate from the rest of the aptos-core crates. We'll update this ticket when we there is further progress on that.