aptos-labs / aptos-indexer-processors

Set of core processors that index data on the Aptos blockchain
https://aptos.dev/indexer/indexer-landing
60 stars 72 forks source link

replace enums with struct with dyn trait to address perofrmance risk with having too many enums #614

Closed yuunlimm closed 1 week ago

yuunlimm commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

larry-aptos commented 1 week ago

do you consider/evaluate enum_dispatch? which do you prefer(dispatch vs downcast)?

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 25.58140% with 64 lines in your changes missing coverage. Please review.

Project coverage is 48.7%. Comparing base (3d22e3b) to head (5b9608c).

Files with missing lines Patch % Lines
rust/sdk-processor/src/parquet_processors/mod.rs 29.7% 52 Missing :warning:
...ust/sdk-processor/src/steps/common/gcs_uploader.rs 0.0% 7 Missing :warning:
...uet_default_processor/parquet_default_extractor.rs 0.0% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #614 +/- ## ===================================== Coverage 48.7% 48.7% ===================================== Files 186 186 Lines 24904 24909 +5 ===================================== + Hits 12129 12151 +22 + Misses 12775 12758 -17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: