The usage of instanceof keeps causing a lot of problem, specifically when using the TS sdk from different bundles.
Sometimes this is due to misconfiguration, some other times there's no way around it (e.g. injected wallet plugins).
This PR attempts to remove the usage of instanceof from all flows were inputs might come from different bundles:
When using Account.from with an instance of AccountAddress
When verifying a signature using an instance of Signature
When simulating a transaction using an instance of PublicKey
Test Plan
CI, as well as manually testing Wapal that is currently unable to integrate with AptosConnect because of the above problem.
Description
The usage of
instanceofkeeps causing a lot of problem, specifically when using the TS sdk from different bundles. Sometimes this is due to misconfiguration, some other times there's no way around it (e.g. injected wallet plugins).This PR attempts to remove the usage of
instanceoffrom all flows were inputs might come from different bundles:Account.fromwith an instance ofAccountAddressSignaturePublicKeyTest Plan
CI, as well as manually testing Wapal that is currently unable to integrate with AptosConnect because of the above problem.