Open JackyWYX opened 1 month ago
Hi @JackyWYX , thanks for reporting.
The adapter logic is - first check the wallet supports submitTransaction
, if it does it would use the network set on the wallet.
But when a wallet doesnt support that feature, then the adapter assumes only Aptos networks. I think adding optional fullnode
(and some other configs like indexerurl
, etc) to the adapter APIs makes sense - we would need it on the Provider level and on AdapterCore for some APIs - submitTransaction
, signTransaction
, signAndSubmitTransaction
Hi @JackyWYX , thanks for reporting.
The adapter logic is - first check the wallet supports
submitTransaction
, if it does it would use the network set on the wallet.But when a wallet doesnt support that feature, then the adapter assumes only Aptos networks. I think adding optional
fullnode
(and some other configs likeindexerurl
, etc) to the adapter APIs makes sense - we would need it on the Provider level and on AdapterCore for some APIs -submitTransaction
,signTransaction
,signAndSubmitTransaction
Hello, do you have a time schedule?
Hi @JackyWYX , thanks for reporting. The adapter logic is - first check the wallet supports
submitTransaction
, if it does it would use the network set on the wallet. But when a wallet doesnt support that feature, then the adapter assumes only Aptos networks. I think adding optionalfullnode
(and some other configs likeindexerurl
, etc) to the adapter APIs makes sense - we would need it on the Provider level and on AdapterCore for some APIs -submitTransaction
,signTransaction
,signAndSubmitTransaction
Hello, do you have a time schedule?
could probably only start working on it mid-late September - are you open to submit a PR for that?
Description
Code
During
submitTransaction
, a newAptosConfig
is created, but the new config does not include the optionalfullnode
field in the config data structure, which will lead tofullnode
config does not take effect when submitting transaction.Proposed solution
Add optional
fullnode
url and other optional settings fromAptosConfig
when creating the newAptosConfig
atsubmitTransaction