Update create-dapp-app docs

aptos-labs / developer-docs

Source for the Aptos developer docs

https://aptos.dev

Apache License 2.0

845 stars 79 forks source link

Update create-dapp-app docs #462

Closed jmintuitive closed 1 month ago

jmintuitive commented 2 months ago

Description

Update docs for readability and actionability.

Only had time to go through the homepage and the digital-asset template.

For the digital asset template I was running into an issue with formatting the address, and was getting this error. Help resolving this error would be appreciated :) cc: @gregnazario (if you happen to know the fix, or know were to find a working example config file for create-dapp-app digital asset version).

Error:

.env:

VITE_APP_NETWORK=testnet
VITE_CREATOR_ADDRESS=0x71e3cdf1ef86d575ae38c7c2d19f22b8c88eb2b15082691782e5b8c8da401568
VITE_MODULE_ADDRESS=0x59f86a8bae077b39d32a71b8d4641c558c0198765b6e7997a2d0a8545c1e3237

(I'm not clear what the "Owner" one is. Note the VITE_MODULE_ADDRESS is auto generated, so I'm confused why it wouldn't be formatted properly - maybe Owner is referring to something else entirely?)

Checklist

Do all Lints pass?
- [ ] Have you ran pnpm spellcheck?
- [X] Have you ran pnpm fmt?
- [X] Have you ran pnpm lint?

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
developer-docs-nextra	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2024 2:28pm

netlify[bot] commented 2 months ago

Deploy Preview for aptos-developer-docs ready!

Name	Link
Latest commit	4fa25e5b3e678a580a97b4a80e48621bd782d6a0
Latest deploy log	https://app.netlify.com/sites/aptos-developer-docs/deploys/66798196e9ce9b0008424ed7
Deploy Preview	https://deploy-preview-462--aptos-developer-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0xmaayan commented 2 months ago

What wallet did you use as the collection_creator_address? This happens if you use the google account (which actually should be hidden on the wallet selector modal)

jmintuitive commented 2 months ago

What wallet did you use as the collection_creator_address? This happens if you use the google account (which actually should be hidden on the wallet selector modal)

Ah yes, I did use the Google one for convenience since I don't have an Aptos wallet yet. I'll update the doc so that it warns against it.

0xmaayan commented 1 month ago

CAD templates that require upload files dont use AptosConnect anymore

jmintuitive commented 1 month ago

@0xmaayan I'm a bit confused as to why this PR was closed instead of merged. I think the updated steps make it a lot simpler to figure out how to use the create-dapp-app. (The AptosConnect thing I mentioned at the top was just an issue I ran into - not the main point of the PR). Happy to message offline as well :)