aptos-labs / petra-wallet

Public issue tracker for Petra Wallet on Aptos
https://petra.app
95 stars 61 forks source link

Run and show transaction simulation information for feePayerTransactions (or otherwise show what the transaction will do) #37

Closed aaronTufts closed 1 day ago

aaronTufts commented 3 months ago

Ask Show transaction details and effects for feePayer transactions.

Pain/Benefit Sponsoring transactions can help increase user acquisition and engagement, in DeFi and other apps. But, if users don't know what they're approving, it's not worth the risk for them.

Details I'm testing using Petra for user transaction signing. I'm using @aptos-labs/wallet-adapter-react and feePayer transactions. It's working fine, but I have this issue: in the signing modal when it's a feePayer transaction, there is no "Simulation result" box that shows the user the details of what's happening in the transaction. They only see the function being called and the Fee Payer Address. This is the same whether I sign with the ultimate feePayer's address or the 0x0 address.

Screenshot 2024-08-08 at 10 24 31 AM

Screenshot 2024-08-08 at 12 12 52 PM
aaronTufts commented 1 day ago

This has now been addressed