search

aptos-labs / petra-wallet

Public issue tracker for Petra Wallet on Aptos
https://petra.app
95 stars 61 forks source link

[BUG] Petra wallet unstable connection status when refreshing the page #7

Closed jillxuu closed 1 year ago

jillxuu commented 1 year ago

Issue

When frequently refreshing pages that use Petra wallet connections, people noticing that wallet connection prompt is triggered from time to time. When prompt is triggered, await window.petra.isConnected() in the react inspector console will return false.

Issue Impact

This issue has affected ANS, Explorer, and Wallet Adapter, which use Petra as one of the wallet connection providers.

https://user-images.githubusercontent.com/121921928/221096986-b2265bd2-7e9d-4c68-8347-20ce984e9751.mov

https://user-images.githubusercontent.com/121921928/221097010-051c88b6-9d2e-4d93-8f0e-ec3793c91478.mov

0xmaayan commented 1 year ago

also,

  1. it doesn't happen on https://governance.aptosfoundation.org/ where we use only Petra
  2. it doesn't happen on local env (localhost) when using the adapter - local react and nextjs apps
Tam78787 commented 1 year ago

150 ATP

Vào 12:29, Th 6, 24 thg 2, 2023 Maayan @.***> đã viết:

also,

  1. it doesn't happen on https://governance.aptosfoundation.org/ where we use only Petra
  2. it doesn't happen on local env (localhost) when using the adapter - local react and nextjs apps

— Reply to this email directly, view it on GitHub https://github.com/aptos-labs/petra-wallet/issues/7#issuecomment-1442830281, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5BNNEAHG66NLB2CPE5UB33WZBBK7ANCNFSM6AAAAAAVGPDP6E . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hariria commented 1 year ago

I think this is resolved @0xmaayan @jillxuu @kent-white ? Can I close?

kent-white commented 1 year ago

yes resolved