search

apvarun / toastify-js

Pure JavaScript library for better notification messages
https://apvarun.github.io/toastify-js/
MIT License
2.13k stars 230 forks source link

About ClassName #34

Closed AuroraAndersson closed 4 years ago

AuroraAndersson commented 5 years ago

When I set classname:error,it didn't have any diffent.

apvarun commented 5 years ago

Can you create a minimal reproduction? From what I can see, the class name is being appended to the created Toast. Reference: https://codesandbox.io/s/toastify-classname-option-ucfrn

AuroraAndersson commented 5 years ago

Toastify({ text: "This is a toast", className: "error" }).showToast(); This code is not any different from default.

apvarun commented 5 years ago

Reference: https://codesandbox.io/s/toastify-classname-option-ucfrn

@LimeZky I've updated this Sandbox demo to show a visual difference. I think this would make things clear for you.

joaquinwojcik commented 4 years ago

I think this issue has been solved at some point, cause I've seen that demo and it's working well.

image

Should we close this?

apvarun commented 4 years ago

Closing this as it's fixed now.