search

apvarun / toastify-js

Pure JavaScript library for better notification messages
https://apvarun.github.io/toastify-js/
MIT License
2.13k stars 230 forks source link

Toast should use semantic HTML #39

Closed NullVoxPopuli closed 2 years ago

NullVoxPopuli commented 4 years ago

for best accessibility: button for interactive a for links

AStoker commented 3 years ago

The toasts themselves should be contained inside of a div, however, I agree that things like the close button should be an actual button rather than a span. Where are the anchor tags used?

kdoroszewicz commented 2 years ago

I created a PR that fixes markup for close button. I didn't see any use of anchor tag.