Add support to close notification from a child element of "toast-close"

apvarun / toastify-js

Pure JavaScript library for better notification messages

https://apvarun.github.io/toastify-js/

MIT License

2.13k stars 230 forks source link

Add support to close notification from a child element of "toast-close" #44

Closed t12ung closed 4 years ago

t12ung commented 4 years ago

Customizing the close button using a font library like FontAwesome can dynamically create a child svg element when using its SVG+JS framework. When this child element triggers the close event, it only the close button disappears.
If close event target is not "toast-close" element, search for the closest parent which has this className and pass this before trying to close the closeElement's parent.
Utiltises .closest(), included Polyfill to support IE9+.

apvarun commented 4 years ago

@t12ung Thanks for the PR. I understand your problem here. Looking back at the code, I think it's better to do this.removeElement(this.toastElement); as we already have an element reference and avoids the unnecessary parent element computation. What do you think?

t12ung commented 4 years ago

Yes, of course. That would be much more efficient. I've updated the code for this PR.