search

aqandrew / fret-zone

🎸 React clone of Guitar Pro tab editor (WIP)
https://fret.zone/
48 stars 5 forks source link

ArrowLeft/ArrowRight listeners add/remove dotting for no reason #20

Closed aqandrew closed 4 years ago

aqandrew commented 4 years ago

Repro steps:

  1. Select a dotted note.
  2. Use ArrowLeft/ArrowRight to select an adjacent duration containing at least one note.
    • This can be a duration in an adjacent measure.
  3. If the adjacent duration was not dotted, it will be now.

Similar behavior occurs when a dotted note is navigated to from an undotted note; the target note's dotting is removed.

This bug doesn't occur when selecting adjacent durations on click.

Note: Changing a duration's dotting when selecting with arrow keys is desired when the target duration does not contain any notes.