aqbal / firefox-mac-pdf

Automatically exported from code.google.com/p/firefox-mac-pdf
0 stars 0 forks source link

Disabled key bindings when the PDF gets focus (Patch) #175

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Open a PDF in the plugin
2. Click in the PDFView, so we can navigate using key strokes
3. Try to use any key binding defined by Firefox or by an extension.

What version of the plugin are you using? Which version of Firefox?
firefox-mac-pdf SVN r102, Firefox 3.6.12

Please provide any additional information below.

The plugin effectively disables Firefox's key bindings (as well as those 
defined by any extension) as soon as you click on a PDFView, to favor the
view's key bindings. What about a different approach where we re-implement the 
important PDF bindings (such as up, down, page up etc.) and leave everything 
else untouched?

The attached patch (against r102) effectively disables the PDFView's (few) key 
bindings and re-implements only those that we want to use (which also removes 
an obscure hack in the relevant code with a - hopefully - a bit less obscure 
hack ;) ). The result is that Firefox's key bindings stay intact, no matter 
what we do in the PDFView.

Original issue reported on code.google.com by philip.k...@googlemail.com on 4 Dec 2010 at 2:40

Attachments: