aqbal / firefox-mac-pdf

Automatically exported from code.google.com/p/firefox-mac-pdf
0 stars 0 forks source link

Drop Carbon code and use Cocoa code to be able to run as 64bit plugin under a 64bit running Firefox #198

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Use Firefox 4+ in 64bit mode (default)
2. Install PDF Plugin
3. You have to run Firefox in (non-default) 32bit mode to be able to use this 
Plugin. But Firefox per default runs in 64bit mode on more modern Macs with 
Leopard or Snow Leopard.

What version of the plugin are you using? Which version of Firefox?

firefox-mac-pdf 1.2.0. Firefox 4.0.1 (64bit)

Please provide any additional information below.

Drop Carbon code and use Cocoa code.
To be able to run the plugin as a 64bit plugin under a 64bit Firefox using 
MacOSX' 64bit Cocoa API rather than its Non-64bit, functional limited and 
official deprecated Carbon API.

Original issue reported on code.google.com by sie...@gmail.com on 29 Apr 2011 at 12:06

GoogleCodeExporter commented 8 years ago
this plugin already uses the Cocoa-only PDF Kit, not 32bit Carbon APIs

Original comment by jpmhous...@gmail.com on 23 May 2011 at 3:26

GoogleCodeExporter commented 8 years ago
i shouldn't continue commenting if i don't know what i'm talking about, but 
maybe this is the issue (comment from pdfplugin.mm)
  // select the Carbon event model
  // I'm not absolutely sure that this is necessary, but the documentation
  // suggests that the Cocoa event model is used by default in 64-bit plugins,
  // which will definitely not work for this plugin.
  // The problem with the Cocoa event model is that there is no way to get the
  // browser's NSWindow or NSView, which we need to attach the PDFView

Original comment by jpmhous...@gmail.com on 23 May 2011 at 3:44

GoogleCodeExporter commented 8 years ago
@ Comment #1:

And what are the error messages and comments in

Issue 179, Comment #c54
http://code.google.com/p/firefox-mac-pdf/issues/detail?id=179#c54

and

Issue 179, Comment #c56
http://code.google.com/p/firefox-mac-pdf/issues/detail?id=179#c56

and

Issue 179, Comment #c60
http://code.google.com/p/firefox-mac-pdf/issues/detail?id=179#c60

saying

<quote src="Issue 179#c54">
Errors generated in Console on attempting to load a PDF:
3/4/11 4:37:22 PM   plugin-container[49446] NPP_New(npp=0x1d183c4,mode=2,argc=5)
3/4/11 4:37:22 PM   [0x0-0xcd2cd2].org.mozilla.firefox[49431]   2011-03-04 
16:37:22.655 plugin-container[49446:903] NPP_New(npp=0x1d183c4,mode=2,argc=5)
3/4/11 4:37:22 PM   [0x0-0xcd2cd2].org.mozilla.firefox[49431]   Carbon event model 
not supported, can't create a plugin instance.
3/4/11 4:37:22 PM   [0x0-0xcd2cd2].org.mozilla.firefox[49431]   ###!!! 
[Child][RPCChannel] Error: Processing error: message was deserialized, but the 
handler returned false (indicating failure)
</quote>

<quote src="Issue 179#c56">
With that error it looks like it's because it's built using the carbon API's 
which are 32 bit only.  Not sure what it would take to create a cocoa version 
(which is the only way to do 64 bit).  Hope it won't take a complete rewrite of 
the core code but that seems likely.
</quote>

<quote src="Issue 179#c60">
In 32-bit Console says...
3/10/11 11:34:20 AM firefox-bin[2822]   NPP_New(npp=0x1d3a1558,mode=2,argc=5)
3/10/11 11:34:20 AM firefox-bin[2822]   firefox-mac-pdf: could not get PDF 
service 
In 64-bit Console says...
3/10/11 11:35:53 AM [0x0-0x38f38f].org.mozilla.firefox[2864]    2011-03-10 
11:35:53.788 plugin-container[2868:903] NPP_New(npp=0x1d46394,mode=2,argc=5)
3/10/11 11:35:53 AM [0x0-0x38f38f].org.mozilla.firefox[2864]    Carbon event model 
not supported, can't create a plugin instance.
</quote>

about and give a hint for, when saying "Carbon event model not supported, can't 
create a plugin instance"?

Original comment by sie...@gmail.com on 23 May 2011 at 3:56