search

aqtech-ca / mctreesearch4j

MIT License
7 stars 1 forks source link

Enable extensible solvers #20

Closed JunTaoLuo closed 3 years ago

larkz commented 3 years ago

@JunTaoLuo game performance in the app seem to degrade with the new changes

> Task :test FAILED

GridWorldTests > gridWorldTestOpenSpace() FAILED
    java.lang.Exception at GridWorldTests.kt:55

GridWorldTests > gridWorldTestWall() FAILED
    java.lang.Exception at GridWorldTests.kt:55

Game2048Tests > game2048testSenario1() FAILED
    java.lang.Exception at Game2048Tests.kt:39

Game2048Tests > game2048testScenario2() FAILED
    java.lang.Exception at Game2048Tests.kt:39

4 tests completed, 4 failed

FAILURE: Build failed with an exception.
larkz commented 3 years ago

@JunTaoLuo the interface changes to the signatures of each of MDP is causing some friction among the MDP implementation for each of the games, as the solver needs to import them into the app. Mind taking a look at how each game MDP is implemented, and if its implemented correctly? At least see that the unit tests run.