irrigation.py irrigation method 1 has test code hard-code value of 15 mm

aquacropos / aquacrop

AquaCrop-OSPy: Python implementation of AquaCrop-OS

https://aquacropos.github.io/aquacrop/

Apache License 2.0

102 stars 73 forks source link

irrigation.py irrigation method 1 has test code hard-code value of 15 mm #132

Closed mrmayn closed 3 months ago

mrmayn commented 8 months ago

Hello, in irrigation.py for Irr Method 1, there is a hard-coded value put in for testing purposes that was left in. Could you update the main branch by removing the hard code and restoring the main code, Irr = min(IrrMngt_MaxIrr, IrrReq) ? I thought I would raise the issue here so others who use the package for the first time don't have the same issue.

tfoster88 commented 4 months ago

Thanks @Han-Su22 and @oleksmialyk. I've been away these past few weeks, but will look into this over coming days. Clearly an issue with irrigation test that will be an easy fix, and we will check the others raised by Oleks at same time and implement any changes needed

tfoster88 commented 3 months ago

This has now been fixed in last release