aquacropos / aquacrop

AquaCrop-OSPy: Python implementation of AquaCrop-OS
https://aquacropos.github.io/aquacrop/
Apache License 2.0
102 stars 73 forks source link

Fix issue caused by SwitchGDDType and NewCond_zGW #176

Open fclof opened 2 months ago

fclof commented 2 months ago

I was trying to run some simulations with the new 3.0.9 version, and I met issues like in #163 and #164 . I figured it out that you just need to change SwitchGDDType to int instead of str, and it will compile.

However, this fix is not enough, because there is another issue caused by return (NewCond_th_fc_Adj, None, None) in check_groundwater_table.py, the last 'None' (NewCond_zGW) breaks root_development()'s expected data type (NewCond_zGW: float). So I just changed it to 0, and it finally worked.