search

aqualinkorg / aqualink-app

Aqualink.org Ocean Monitoring Application
MIT License
34 stars 12 forks source link

Refactor water sampling card #901

Closed echaidemenos closed 1 year ago

echaidemenos commented 1 year ago

resolves https://github.com/aqualinkorg/aqualink-app/issues/880

This PR merges old water sampling card (SONDE) with HUI card. Now SONDE and HUI cards show data from the latest sonde data upload. SONDE card shows mean values, where HUI card shows geometric means. The goal here is to make water sampling card more modular, in order to accept more metrics from different source, since we also enabled uploading any metric form any source here: https://github.com/aqualinkorg/aqualink-app/pull/854

For next steps, we could form some water sampling metric preference list and show the first 6 metrics that do exists in the latest data upload. We could also implement a switch or a per metric preference for choosing between geometric or arithmetic mean

(also fixes some visual bug in buoy observation card)

github-actions[bot] commented 1 year ago

Build succeeded and deployed at https://aqualink-app-901.surge.sh (hash 0df1473401bc7e039ee5e4b1c011b260d63785c1 deployed at 2023-07-31T12:31:53)