search

aquametalabs / aquameta

Web development platform built entirely in PostgreSQL
GNU General Public License v3.0
1.1k stars 52 forks source link

Audit usage of pg_extensions_config_dump() #258

Closed erichanson closed 1 year ago

erichanson commented 1 year ago

PostgreSQL's pg_dump doesn't dump data in tables created by extensions, by default. To enable it, you have to call pg_catalog.pg_extension_config_dump(), per-table. They call it "config" data, making it pretty clear that first-class data within extensions is not a pattern they were going for. This is a big foot-gun: When using Aquameta, one would expect that doing a pg_dump would capture the data within its extensions. Bundle works around this, by calling the above function on every table (I hope). The rest of the extensions should as well, or we should stop using extensions all together.

erichanson commented 1 year ago

Stop using extensions that contain tables/data instead.