aquametalabs / aquameta

Web development platform built entirely in PostgreSQL
GNU General Public License v3.0
1.1k stars 52 forks source link

Resource function format may be too custom #264

Closed micburks closed 1 year ago

micburks commented 1 year ago

The path pattern for endpoint.resource_function uses a format I haven't seen before. {$var}. This pattern could really be anything, but every time I try to write one I end up writing ${var}, mostly from bash and js experience. I'd prefer that format just to avoid confusion.

Have you explored using postgres string format sequences instead? Even though we have to use a regex for capturing, it might be more of-the-domain to use %1$s or the like.

This issue is partly a question. Does this format come from somewhere? If so, which is the more familiar pattern to use? As is, it confused me, so before we lean on this heavily, it would be wise to consider our options

micburks commented 1 year ago

Fixed in #269 on 0.4