search

aquanauts / alogamous

A log anomaly detection framework
MIT License
1 stars 9 forks source link

Analyzer tests should be decoupled from analyzer base class #58

Closed kitrady closed 3 months ago

kitrady commented 4 months ago

Right now, many of the tests for the analyzers work by running the analyze_log_stream method from the analyzer base class, meaning if we change the behavior of analyze_log_stream, these tests will fail despite changing nothing about the analyzers themselves. Instead, these tests should probably run the individual read_log_line and report methods of the analyzer they are testing (like the info_counter_test is doing here and here, for example), so that they will only fail if those specific methods are changed incorrectly.

kitrady commented 4 months ago

The specific tests with this issue are the duplicate log messages test, the error counter test, and the warning analyzer test

kitrady commented 3 months ago

I'm working on this