Neovim exec not found on MacOS, entry in registry incorrect

mab commented 1 year ago

package name

neovim/neovim@stable

aqua version

aqua version 2.10.1 (fbf3b157b21897fa2f315fbc30474acafded108d)

Environment

OS (Windows, Linux, macOS, etc): MacOS 13.4.1
CPU Architecture (amd64, arm64, etc): both i386 and arm64

Overview

How to reproduce

aqua.yaml


# aqua - Declarative CLI Version Manager
# https://aquaproj.github.io/
# checksum:
#   # https://aquaproj.github.io/docs/reference/checksum/
#   enabled: true
#   require_checksum: true
#   supported_envs:
#   - all
registries:

type: standard ref: v4.40.0 # renovate: depName=aquaproj/aqua-registry packages:
name: neovim/neovim@stable
name: twpayne/chezmoi@v2.37.0

executed command and output aqua install and run nvim --version

❯ nvim --version
INFO[0000] download and unarchive the package            aqua_version=2.10.1 env=darwin/amd64 exe_name=nvim package=neovim/neovim package_name=neovim/neovim package_version=stable program=aqua registry=standard
ERRO[0004] check file_src is correct                     aqua_version=2.10.1 env=darwin/amd64 error="check file_src is correct: exe_path isn't found: stat /Users/mab/.local/share/aquaproj-aqua/pkgs/github_release/github.com/neovim/neovim/stable/nvim-macos.tar.gz/nvim-osx64/bin/nvim: no such file or directory" exe_name=nvim exe_path=/Users/mab/.local/share/aquaproj-aqua/pkgs/github_release/github.com/neovim/neovim/stable/nvim-macos.tar.gz/nvim-osx64/bin/nvim file_name=nvim package=neovim/neovim package_name=neovim/neovim package_version=stable program=aqua registry=standard
ERRO[0004] executable files aren't found
Files in the unarchived package (Only 30 files are shown):
nvim-macos/bin/nvim
nvim-macos/lib/nvim/parser/c.so
nvim-macos/lib/nvim/parser/lua.so
nvim-macos/lib/nvim/parser/query.so
nvim-macos/lib/nvim/parser/vim.so
nvim-macos/lib/nvim/parser/vimdoc.so
nvim-macos/share/icons/hicolor/128x128/apps/nvim.png
nvim-macos/share/locale/af/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/ca/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/cs/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/cs.cp1250/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/da/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/de/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/en_GB/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/eo/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/es/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/fi/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/fr/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/ga/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/it/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/ja/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/ja.euc-jp/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/ko.UTF-8/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/nb/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/nl/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/no/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/pl.UTF-8/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/pt_BR/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/ru/LC_MESSAGES/nvim.mo
nvim-macos/share/locale/sk/LC_MESSAGES/nvim.mo
aqua_version=2.10.1 env=darwin/amd64 exe_name=nvim package=neovim/neovim package_name=neovim/neovim package_version=stable program=aqua registry=standard
FATA[0004] aqua failed                                   aqua_version=2.10.1 env=darwin/amd64 error="check file_src is correct" exe_name=nvim package=neovim/neovim package_version=stable program=aqua

Location of bin is different to the one in the `registry.yaml``


❯ l /Users/mab/.local/share/aquaproj-aqua/pkgs/github_release/github.com/neovim/neovim/stable/nvim-macos.tar.gz
total 0
drwxr-xr-x  3 dimbaumg  staff    96B Aug 18 08:47 .
drwxr-xr-x  3 dimbaumg  staff    96B Aug 18 08:47 ..
drwxr-xr-x  5 dimbaumg  staff   160B Aug 18 08:47 nvim-macos
❯ /Users/mab/.local/share/aquaproj-aqua/pkgs/github_release/github.com/neovim/neovim/stable/nvim-macos.tar.gz/nvim-macos/bin/nvim --version
NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3

system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/usr/local/share/nvim"

Run :checkhealth for more info


## Expected Behaviour

- running `nvim` should download neovim and execute it 

## Actual Behaviour

- running `nvim` downloads neovim but does not execute it

## Important Factoids

- In https://github.com/aquaproj/aqua-registry/blob/a8e9b72686d0269e6065b1912e81132dc91cc7a6/pkgs/neovim/neovim/registry.yaml the override for darwin is not correct
```yaml
    files:
      - name: nvim
        src: nvim-{{.OS}}/bin/nvim
    overrides:
      - goos: windows
        format: zip
    version_constraint: semver(">= 0.7.2")
    version_overrides:
      - version_constraint: "true"
        overrides:
          - goos: windows
            format: zip
          - goos: darwin
            files:
              - name: nvim
                src: nvim-osx64/bin/nvim

Question is how to correct it? The override and semver is for windows and darwin. For neovim 0.9.1 on darwin the override is not needed anymore. I have not done a research on since when the structure has changed.

References

pkgs/neovim/neovim/registry.yaml

mab commented 1 year ago

Problem is that I used stable (neovim/neovim@stable and therefore the version_constraint: semver(">= 0.7.2") does not work. I switched to 0.9.1.

suzuki-shunsuke commented 1 year ago

Could you specify the semver such as v0.9.1 instead of stable? aqua treats each package version is immutable, so once aqua installs the version stable, aqua doesn't update it even if the version stable is updated.

I confirmed v0.9.1 works well.

https://github.com/aquaproj/aqua-registry/pull/14714

mab commented 1 year ago

Stable should not be used -> all works as expected.

aquaproj / aqua-registry