aquaproj / aqua-registry

aqua's Standard Registry
https://aquaproj.github.io
MIT License
99 stars 102 forks source link

Neovim exec not found on MacOS, entry in registry incorrect #14713

Closed mab closed 1 year ago

mab commented 1 year ago

package name

aqua version

aqua version 2.10.1 (fbf3b157b21897fa2f315fbc30474acafded108d)

Environment

Overview

How to reproduce

Run :checkhealth for more info


## Expected Behaviour

- running `nvim` should download neovim and execute it 

## Actual Behaviour

- running `nvim` downloads neovim but does not execute it

## Important Factoids

- In https://github.com/aquaproj/aqua-registry/blob/a8e9b72686d0269e6065b1912e81132dc91cc7a6/pkgs/neovim/neovim/registry.yaml the override for darwin is not correct
```yaml
    files:
      - name: nvim
        src: nvim-{{.OS}}/bin/nvim
    overrides:
      - goos: windows
        format: zip
    version_constraint: semver(">= 0.7.2")
    version_overrides:
      - version_constraint: "true"
        overrides:
          - goos: windows
            format: zip
          - goos: darwin
            files:
              - name: nvim
                src: nvim-osx64/bin/nvim

References

mab commented 1 year ago

Problem is that I used stable (neovim/neovim@stable and therefore the version_constraint: semver(">= 0.7.2") does not work. I switched to 0.9.1.

suzuki-shunsuke commented 1 year ago

Could you specify the semver such as v0.9.1 instead of stable? aqua treats each package version is immutable, so once aqua installs the version stable, aqua doesn't update it even if the version stable is updated.

I confirmed v0.9.1 works well.

mab commented 1 year ago

Stable should not be used -> all works as expected.