search

aquaproj / aqua

Declarative CLI Version manager written in Go. Support Lazy Install, Registry, and continuous update with Renovate. CLI version is switched seamlessly
https://aquaproj.github.io
824 stars 34 forks source link

1Password CLI Shell Plugin #3068

Open nikolay opened 2 weeks ago

nikolay commented 2 weeks ago

Feature Overview

https://developer.1password.com/docs/cli/shell-plugins/contribute/

Why is the feature needed?

Otherwise, the AQUA_GITHUB_TOKEN or GITHUB_TOKEN should always be set and exposed in the shell.

Workaround

No response

Example Code

No response

Note

No response

suzuki-shunsuke commented 2 weeks ago

Thank you for your proposal. I'm not familiar with 1Password CLI Shell Plugin, but this issue means installing 1Password CLI Shell Plugin via aqua? I'll look into how to install plugins.

aqua doesn't support some plugin mechanism, so I'm not sure if aqua can support 1Password CLI Shell Plugin. https://aquaproj.github.io/docs/products/aqua-registry/contributing#aqua-cant-support-some-tools-plugin-mechanism

suzuki-shunsuke commented 2 weeks ago

I read the document of 1Password CLI Shell Plugin, but I'm not sure what aqua should do. We need more details.

suzuki-shunsuke commented 2 weeks ago

Oh, I see! This issue means the 1Password CLI Shell Plugin for aqua, which passes GitHub access token to aqua via 1Password.

nikolay commented 2 weeks ago

Yeah, @suzuki-shunsuke, sorry for not being clear. I guess, you support AQUA_GITHUB_TOKEN - I would say it makes sense to pass that and not the generic GITHUB_TOKEN.

suzuki-shunsuke commented 2 weeks ago

I'm concern about the overhead of the plugin. I'm not sure about the detail of the plugin, but if the plugin is executed every time aqua is executed, maybe the overhead affects the user experience. When you execute tools installed by aqua, aqua is executed.

On the other hand, the plugin would improve the security, and the performance should be measured rather than imagined.