aquaproj / aqua

Declarative CLI Version manager written in Go. Support Lazy Install, Registry, and continuous update with Renovate. CLI version is switched seamlessly
https://aquaproj.github.io
841 stars 38 forks source link

It failed to cancel `aqua i` by `Ctrl-C` #456

Closed suzuki-shunsuke closed 2 years ago

suzuki-shunsuke commented 2 years ago

aqua version

Please use the latest version.

$ aqua -v
aqua version 0.8.3 (b2ab7d2a1c47028c563e49d46b09565e1c5b52b9)

Environment

:warning: aqua doesn't support Windows.

Overview

How to reproduce

aqua.yaml should be not partial but complete configuration. Please remove unneeded configuration to reproduce the issue.

~/repos/src/github.com/aquaproj/aqua-registry main
$ git rev-parse HEAD
08d48977e13eb07fd8e8d3a2437db15cb6560da0

https://github.com/aquaproj/aqua-registry/tree/08d48977e13eb07fd8e8d3a2437db15cb6560da0

# aqua.yaml
registries:
- name: standard
  type: local
  path: registry.yaml

packages:
- name: suzuki-shunsuke/ci-info@v2.0.3
- import: pkgs/*.yaml
$ aqua -c aqua-all.yaml i --test
```console $ aqua -c aqua-all.yaml i --test INFO[0000] download and unarchive the package aqua_version=0.8.3 package_name=suzuki-shunsuke/ci-info package_version=v2.0.3 program=aqua registry=standard INFO[0000] download and unarchive the package aqua_version=0.8.3 package_name=abiosoft/colima package_version=v0.2.2 program=aqua registry=standard INFO[0000] download and unarchive the package aqua_version=0.8.3 package_name=accurics/terrascan package_version=v1.12.0 program=aqua registry=standard INFO[0000] download and unarchive the package aqua_version=0.8.3 package_name=abs-lang/abs package_version=2.5.1 program=aqua registry=standard INFO[0003] download and unarchive the package aqua_version=0.8.3 package_name=aelsabbahy/goss package_version=v0.3.16 program=aqua registry=standard INFO[0003] download and unarchive the package aqua_version=0.8.3 package_name=aelsabbahy/goss/dgoss package_version=v0.3.16 program=aqua registry=standard INFO[0003] download and unarchive the package aqua_version=0.8.3 package_name=aelsabbahy/goss/dcgoss package_version=v0.3.16 program=aqua registry=standard INFO[0004] download and unarchive the package aqua_version=0.8.3 package_name=aelsabbahy/goss/kgoss package_version=v0.3.16 program=aqua registry=standard INFO[0004] download and unarchive the package aqua_version=0.8.3 package_name=ahmetb/kubectl-tree package_version=v0.4.1 program=aqua registry=standard INFO[0004] download and unarchive the package aqua_version=0.8.3 package_name=suzuki-shunsuke/github-comment package_version=v4.0.1 program=aqua registry=standard ^CERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=suzuki-shunsuke/github-comment package_version=v4.0.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="copy the body to /Users/shunsuke-suzuki/.aqua/pkgs/github_release/github.com/aelsabbahy/goss/v0.3.16/goss-alpha-darwin-amd64/goss-alpha-darwin-amd64: context canceled" package_name=aelsabbahy/goss package_version=v0.3.16 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="copy the file to the temporal file: context canceled" package_name=ahmetb/kubectl-tree package_version=v0.4.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=suzuki-shunsuke/matchfile package_version=v1.0.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=suzuki-shunsuke/matchfile package_version=v1.0.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=suzuki-shunsuke/tfcmt package_version=v2.1.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=suzuki-shunsuke/tfcmt package_version=v2.1.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=swaggo/swag package_version=v1.7.6 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=swaggo/swag package_version=v1.7.6 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=talos-systems/conform package_version=v0.1.0-alpha.23 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=talos-systems/conform package_version=v0.1.0-alpha.23 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=talos-systems/talos package_version=v0.13.4 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=talos-systems/talos package_version=v0.13.4 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=sysdiglabs/kube-psp-advisor package_version=v2.0.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=sysdiglabs/kube-psp-advisor package_version=v2.0.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=cosmtrek/air package_version=v1.27.8 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=cosmtrek/air package_version=v1.27.8 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=crate-ci/typos package_version=v1.3.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=crate-ci/typos package_version=v1.3.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=create-go-app/cli package_version=v3.2.2 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=create-go-app/cli package_version=v3.2.2 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=crossplane/crossplane package_version=v1.5.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="send http request: Get \"https://releases.crossplane.io/stable/v1.5.1/bin/darwin_amd64/crank\": context canceled" package_name=crossplane/crossplane package_version=v1.5.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=cue-lang/cue package_version=v0.4.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=cue-lang/cue package_version=v0.4.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=dandavison/delta package_version=0.11.2 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=dandavison/delta package_version=0.11.2 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=dapr/cli package_version=v1.5.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=dapr/cli package_version=v1.5.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=datreeio/datree package_version=0.14.62 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=datreeio/datree package_version=0.14.62 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=ddosify/ddosify package_version=v0.6.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=ddosify/ddosify package_version=v0.6.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=tcnksm/ghr package_version=v0.14.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=tcnksm/ghr package_version=v0.14.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=tektoncd/cli package_version=v0.21.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=tektoncd/cli package_version=v0.21.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=telepresenceio/telepresence package_version=v2.4.2 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="send http request: Get \"https://app.getambassador.io/download/tel2/darwin/amd64/2.4.2/telepresence\": context canceled" package_name=telepresenceio/telepresence package_version=v2.4.2 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=temporalio/temporal package_version=v1.13.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=temporalio/temporal package_version=v1.13.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=terraform-docs/terraform-docs package_version=v0.16.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=terraform-docs/terraform-docs package_version=v0.16.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=terraform-linters/tflint package_version=v0.33.2 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=terraform-linters/tflint package_version=v0.33.2 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=tfmigrator/cli package_version=v0.2.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=tfmigrator/cli package_version=v0.2.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=tfutils/tfenv package_version=v2.2.2 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="send http request: Get \"https://github.com/tfutils/tfenv/archive/refs/tags/v2.2.2.tar.gz\": context canceled" package_name=tfutils/tfenv package_version=v2.2.2 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=thazelart/terraform-validator package_version=3.1.3 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=thazelart/terraform-validator package_version=3.1.3 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=TheZoraiz/ascii-image-converter package_version=v1.11.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=TheZoraiz/ascii-image-converter package_version=v1.11.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=thought-machine/please package_version=v16.17.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=thought-machine/please package_version=v16.17.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=tilt-dev/ctlptl package_version=v0.6.2 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=tilt-dev/ctlptl package_version=v0.6.2 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=tilt-dev/tilt package_version=v0.23.3 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=tilt-dev/tilt package_version=v0.23.3 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=tinygo-org/tinygo package_version=v0.21.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=tinygo-org/tinygo package_version=v0.21.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=tkuchiki/alp package_version=v1.0.8 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=tkuchiki/alp package_version=v1.0.8 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=TomWright/dasel package_version=v1.22.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=TomWright/dasel package_version=v1.22.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=Traackr/binnacle package_version=0.7.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=Traackr/binnacle package_version=0.7.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=Trendyol/kink package_version=v0.1.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=Trendyol/kink package_version=v0.1.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=trufflesecurity/driftwood package_version=v1.0.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=trufflesecurity/driftwood package_version=v1.0.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=tsenart/vegeta package_version=v12.8.4 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=tsenart/vegeta package_version=v12.8.4 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=twpayne/chezmoi package_version=v2.9.2 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=twpayne/chezmoi package_version=v2.9.2 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=variantdev/vals package_version=v0.14.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=variantdev/vals package_version=v0.14.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=vektra/mockery package_version=v2.9.4 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=vektra/mockery package_version=v2.9.4 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=Versent/saml2aws package_version=v2.33.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=Versent/saml2aws package_version=v2.33.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=vmware-tanzu/carvel-imgpkg package_version=v0.23.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=vmware-tanzu/carvel-imgpkg package_version=v0.23.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=vmware-tanzu/carvel-kapp package_version=v0.43.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=vmware-tanzu/carvel-kapp package_version=v0.43.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=vmware-tanzu/carvel-kbld package_version=v0.31.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=vmware-tanzu/carvel-kbld package_version=v0.31.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=vmware-tanzu/carvel-kwt package_version=v0.0.6 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=vmware-tanzu/carvel-kwt package_version=v0.0.6 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=vmware-tanzu/carvel-vendir package_version=v0.23.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=vmware-tanzu/carvel-vendir package_version=v0.23.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=vmware-tanzu/carvel-ytt package_version=v0.38.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=vmware-tanzu/carvel-ytt package_version=v0.38.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=vmware-tanzu/velero package_version=v1.7.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=vmware-tanzu/velero package_version=v1.7.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=wagoodman/dive package_version=v0.10.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=wagoodman/dive package_version=v0.10.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=weaveworks/eksctl package_version=v0.76.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=weaveworks/eksctl package_version=v0.76.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=wtfutil/wtf package_version=v0.40.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=wtfutil/wtf package_version=v0.40.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=x-motemen/ghq package_version=v1.2.1 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=x-motemen/ghq package_version=v1.2.1 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=XAMPPRocky/tokei package_version=v12.1.2 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=XAMPPRocky/tokei package_version=v12.1.2 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=xo/usql package_version=v0.9.5 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=xo/usql package_version=v0.9.5 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=xtaci/kcptun package_version=v20210922 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=xtaci/kcptun package_version=v20210922 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=ycd/dstp package_version=v0.4.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=ycd/dstp package_version=v0.4.0 program=aqua registry=standard INFO[0005] download and unarchive the package aqua_version=0.8.3 package_name=zaquestion/lab package_version=v0.23.0 program=aqua registry=standard ERRO[0005] install the package aqua_version=0.8.3 error="get the GitHub Release by Tag: context canceled" package_name=zaquestion/lab package_version=v0.23.0 program=aqua registry=standard ^C ^C^C ^C^C^C ```

Debug Output

Please set the environment variable AQUA_LOG_LEVEL=debug and run aqua and tell us the debug output.

$ 

Expected Behaviour

You can cancel aqua i by Ctrl-C.

Actual Behaviour

It failed to cancel aqua i by Ctrl-C.

Important Factoids

References

suzuki-shunsuke commented 2 years ago

https://github.com/aquaproj/aqua/blob/b2ab7d2a1c47028c563e49d46b09565e1c5b52b9/pkg/controller/download_github.go#L57

https://github.com/aquaproj/aqua/blob/949ef6163ed060ef0bc74d206467c5f89d1fe5e2/pkg/controller/install_packages.go#L63-L114