Possession and when gain / when buy Hinterlands cards

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Play Possession
2. On Mary's turn, buy / gain a card with an on gain / on buy effect

I have not checked all cards yet.  Some of them appear to work correctly, but 
many do not.  I will update this issue with other cards as I test them.

Noble Brigand -- This card actually works as expected.  When Mary buys Noble 
Brigand, she attacks everyone else (since this card triggers on buy, not on 
gain).  Then, I gain the revealed Silver/Gold cards, due to the Possession 
effect.  (Among other things, this can cause me to steal from myself, which is 
kind of awesome.)  After this happens, I gain the Noble Brigand.

Inn -- When Mary buys Inn, I gain Inn.  When I gain Inn, the on-gain effect 
should trigger for me.  Instead, it does not trigger for anyone.  

Ill-Gotten Gains -- When Mary buys this and I gain it, I expect the attack to 
trigger.  I also expect that I will gain the Curse that Mary would have gained. 
 Instead, the attack does not trigger.  (Ill-Gotten gains may also be crashing 
the app.  Further investigation is needed.)

Farmlands -- This is the other "on buy" trigger.  When Mary buys Farmlands, I 
expect her to trash a card (to be returned at the end of the turn), and I 
expect to gain a card costing 2 more than the trashed card.  Instead, something 
else happens.  (I will update with details.)

Cards I have not yet tested which may have issues:  Duchess, Nomad Camp, Cache, 
Embassy, Mandarin, Border Village

Original issue reported on code.google.com by August.D...@gmail.com on 24 Feb 2012 at 3:53

[GoogleCodeExporter]

I worked on the possession code and wrote tests for Noble Brigand, Inn, 
Ill-Gotten Gains, and Farmland. Those seem to be working correctly now. I'll 
take a look at the others mentioned this weekend.

Original comment by tkdenni...@gmail.com on 2 Mar 2012 at 12:43

[GoogleCodeExporter]

This issue was closed by revision r543.

Original comment by tkdenni...@gmail.com on 13 Jul 2012 at 9:37

• Changed state: Fixed