ACS_ULCORNER and ACS_LLCORNER switched

[GoogleCodeExporter]

When I print goncurses.ACS_ULCORNER, it is a lower left corner character.  And 
when I print concourses.ACS_LLCORNER, it is an upper left corner character.

If you look at curses.h, the symbols are defined as:

#define ACS_ULCORNER    NCURSES_ACS('l') /* upper left corner */
#define ACS_LLCORNER    NCURSES_ACS('m') /* lower left corner */
#define ACS_URCORNER    NCURSES_ACS('k') /* upper right corner */
#define ACS_LRCORNER    NCURSES_ACS('j') /* lower right corner */

So the order is LR, UR, UL, LL.

But in defs_posix.go, you have the order as LR, UR, LL, UL.

Thanks!

Daniel

Original issue reported on code.google.com by daniel.m...@gmail.com on 6 Apr 2014 at 1:05

[GoogleCodeExporter]

It looks like the arrows are also switched.  ACS_RARROW with ACS_LARROW, and 
ACS_UARROW with ACS_DARROW.

Original comment by daniel.m...@gmail.com on 6 Apr 2014 at 1:51

[GoogleCodeExporter]

This issue seems to only affect Linux users and likely OSX, too. Windows users 
are not affected by this bug.

Due to the nature of how the ACS_* definitions were implemented, it may take a 
few days before I find a better, long-term solution than just changing the 
order. Ideally, the solution should allow both the Windows and *nix 
implementations back into the defs.go file.

Original comment by rthornto...@gmail.com on 7 Apr 2014 at 5:03

• Added labels: OpSys-Linux

[GoogleCodeExporter]

Fix pushed in changset 189. Initial testing confirms it to work. Let me know if 
you have any more issues.

I will test tomorrow on Windows and will merge definitions into defs.go if it 
does.

Original comment by rthornto...@gmail.com on 10 Apr 2014 at 4:06

• Changed state: Started

[GoogleCodeExporter]

Looks good, thank you!

Original comment by daniel.m...@gmail.com on 10 Apr 2014 at 11:45

[GoogleCodeExporter]

Closing issue as fixed.

Original comment by rthornto...@gmail.com on 11 Apr 2014 at 1:35

• Changed state: Fixed